Merge branch 'release-v1.2.x'

Author: damianmalczewski

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/autoconfigure/ProblemParameterConfiguration.java

@@ -9,6 +9,7 @@
 import io.github.problem4j.spring.web.parameter.MethodValidationResultSupport;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.annotation.Order;
@@ -19,6 +20,7 @@
  * Configuration for parameter support components, such as method parameter name resolution and
  * binding / method validation result conversion.
  */
+@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.ANY)
 @Configuration(proxyBeanMethods = false)
 class ProblemParameterConfiguration {
 

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/autoconfigure/ProblemResolverConfiguration.java

@@ -16,6 +16,7 @@
 
 import io.github.problem4j.spring.web.ProblemFormat;
 import io.github.problem4j.spring.web.parameter.BindingResultSupport;
+import io.github.problem4j.spring.web.parameter.MethodParameterSupport;
 import io.github.problem4j.spring.web.parameter.MethodValidationResultSupport;
 import io.github.problem4j.spring.web.resolver.BindProblemResolver;
 import io.github.problem4j.spring.web.resolver.ConstraintViolationProblemResolver;
@@ -254,8 +255,9 @@ ServerErrorProblemResolver serverErrorProblemResolver(ProblemFormat problemForma
   static class ServerWebInputProblemConfiguration {
     @ConditionalOnMissingBean(ServerWebInputProblemResolver.class)
     @Bean
-    ServerWebInputProblemResolver serverWebInputProblemResolver(ProblemFormat problemFormat) {
-      return new ServerWebInputProblemResolver(problemFormat);
+    ServerWebInputProblemResolver serverWebInputProblemResolver(
+        ProblemFormat problemFormat, MethodParameterSupport methodParameterSupport) {
+      return new ServerWebInputProblemResolver(problemFormat, methodParameterSupport);
     }
   }
 

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/parameter/DefaultBindingResultSupport.java

@@ -33,9 +33,7 @@ public List<Violation> fetchViolations(BindingResult result) {
    *
    * <p>{@code isBindingFailure() == true} usually means that there was a failure in creation of
    * object from values taken out of request. Most common one is validation error or type mismatch
-   * between {@code @ModelAttribute}-annotated argument and one of its values. Consider running
-   * {@code WebExchangeBindExceptionWebFluxTest} or {@code MethodArgumentNotValidExceptionMvcTest}
-   * to debug this feature.
+   * between {@code @ModelAttribute}-annotated argument and one of its values.
    *
    * @param bindingResult the {@link BindingResult} containing the validation errors
    * @param error the {@link FieldError} to convert

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/resolver/BindProblemResolver.java

@@ -20,6 +20,7 @@
 import io.github.problem4j.core.ProblemBuilder;
 import io.github.problem4j.core.ProblemContext;
 import io.github.problem4j.core.ProblemStatus;
+import io.github.problem4j.spring.web.IdentityProblemFormat;
 import io.github.problem4j.spring.web.ProblemFormat;
 import io.github.problem4j.spring.web.ProblemSupport;
 import io.github.problem4j.spring.web.parameter.BindingResultSupport;
@@ -52,6 +53,10 @@ public class BindProblemResolver extends AbstractProblemResolver {
 
   private final BindingResultSupport bindingResultSupport;
 
+  public BindProblemResolver() {
+    this(new IdentityProblemFormat());
+  }
+
   public BindProblemResolver(ProblemFormat problemFormat) {
     this(problemFormat, new DefaultBindingResultSupport());
   }

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/resolver/ConstraintViolationProblemResolver.java

@@ -21,6 +21,7 @@
 import io.github.problem4j.core.ProblemBuilder;
 import io.github.problem4j.core.ProblemContext;
 import io.github.problem4j.core.ProblemStatus;
+import io.github.problem4j.spring.web.IdentityProblemFormat;
 import io.github.problem4j.spring.web.ProblemFormat;
 import io.github.problem4j.spring.web.parameter.Violation;
 import jakarta.validation.ConstraintViolation;
@@ -41,6 +42,10 @@
  */
 public class ConstraintViolationProblemResolver extends AbstractProblemResolver {
 
+  public ConstraintViolationProblemResolver() {
+    this(new IdentityProblemFormat());
+  }
+
   public ConstraintViolationProblemResolver(ProblemFormat problemFormat) {
     super(ConstraintViolationException.class, problemFormat);
   }

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/resolver/DecodingProblemResolver.java

@@ -18,6 +18,7 @@
 import io.github.problem4j.core.ProblemBuilder;
 import io.github.problem4j.core.ProblemContext;
 import io.github.problem4j.core.ProblemStatus;
+import io.github.problem4j.spring.web.IdentityProblemFormat;
 import io.github.problem4j.spring.web.ProblemFormat;
 import org.springframework.core.codec.DecodingException;
 import org.springframework.http.HttpHeaders;
@@ -32,6 +33,10 @@
  */
 public class DecodingProblemResolver extends AbstractProblemResolver {
 
+  public DecodingProblemResolver() {
+    this(new IdentityProblemFormat());
+  }
+
   public DecodingProblemResolver(ProblemFormat problemFormat) {
     super(DecodingException.class, problemFormat);
   }

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/resolver/ErrorResponseProblemResolver.java

@@ -17,6 +17,7 @@
 import io.github.problem4j.core.Problem;
 import io.github.problem4j.core.ProblemBuilder;
 import io.github.problem4j.core.ProblemContext;
+import io.github.problem4j.spring.web.IdentityProblemFormat;
 import io.github.problem4j.spring.web.ProblemFormat;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatusCode;
@@ -36,6 +37,10 @@
  */
 public class ErrorResponseProblemResolver extends AbstractProblemResolver {
 
+  public ErrorResponseProblemResolver() {
+    this(new IdentityProblemFormat());
+  }
+
   public ErrorResponseProblemResolver(ProblemFormat problemFormat) {
     super(ErrorResponseException.class, problemFormat);
   }

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/resolver/HandlerMethodValidationProblemResolver.java

@@ -21,6 +21,7 @@
 import io.github.problem4j.core.Problem;
 import io.github.problem4j.core.ProblemBuilder;
 import io.github.problem4j.core.ProblemContext;
+import io.github.problem4j.spring.web.IdentityProblemFormat;
 import io.github.problem4j.spring.web.ProblemFormat;
 import io.github.problem4j.spring.web.parameter.DefaultMethodValidationResultSupport;
 import io.github.problem4j.spring.web.parameter.MethodValidationResultSupport;
@@ -41,6 +42,10 @@ public class HandlerMethodValidationProblemResolver extends AbstractProblemResol
 
   private final MethodValidationResultSupport methodValidationResultSupport;
 
+  public HandlerMethodValidationProblemResolver() {
+    this(new IdentityProblemFormat());
+  }
+
   public HandlerMethodValidationProblemResolver(ProblemFormat problemFormat) {
     this(problemFormat, new DefaultMethodValidationResultSupport());
   }

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/resolver/HttpMediaTypeNotAcceptableProblemResolver.java

@@ -18,6 +18,7 @@
 import io.github.problem4j.core.ProblemBuilder;
 import io.github.problem4j.core.ProblemContext;
 import io.github.problem4j.core.ProblemStatus;
+import io.github.problem4j.spring.web.IdentityProblemFormat;
 import io.github.problem4j.spring.web.ProblemFormat;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatusCode;
@@ -35,6 +36,10 @@
  */
 public class HttpMediaTypeNotAcceptableProblemResolver extends AbstractProblemResolver {
 
+  public HttpMediaTypeNotAcceptableProblemResolver() {
+    this(new IdentityProblemFormat());
+  }
+
   public HttpMediaTypeNotAcceptableProblemResolver(ProblemFormat problemFormat) {
     super(HttpMediaTypeNotAcceptableException.class, problemFormat);
   }

problem4j-spring-web/src/main/java/io/github/problem4j/spring/web/resolver/HttpMediaTypeNotSupportedProblemResolver.java

@@ -18,6 +18,7 @@
 import io.github.problem4j.core.ProblemBuilder;
 import io.github.problem4j.core.ProblemContext;
 import io.github.problem4j.core.ProblemStatus;
+import io.github.problem4j.spring.web.IdentityProblemFormat;
 import io.github.problem4j.spring.web.ProblemFormat;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatusCode;
@@ -35,6 +36,10 @@
  */
 public class HttpMediaTypeNotSupportedProblemResolver extends AbstractProblemResolver {
 
+  public HttpMediaTypeNotSupportedProblemResolver() {
+    this(new IdentityProblemFormat());
+  }
+
   public HttpMediaTypeNotSupportedProblemResolver(ProblemFormat problemFormat) {
     super(HttpMediaTypeNotSupportedException.class, problemFormat);
   }