Merge branch 'release-v1.2.x' into release-v2.2.x

Author: damianmalczewski

problem4j-spring-web/src/test/java/io/github/problem4j/spring/web/resolver/ConstraintViolationProblemResolverTest.java

@@ -0,0 +1,92 @@
+/*
+ * Copyright (c) 2025-2026 The Problem4J Authors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package io.github.problem4j.spring.web.resolver;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import io.github.problem4j.core.Problem;
+import io.github.problem4j.core.ProblemContext;
+import io.github.problem4j.spring.web.parameter.Violation;
+import jakarta.validation.ConstraintViolation;
+import jakarta.validation.ConstraintViolationException;
+import jakarta.validation.Path;
+import java.util.List;
+import java.util.Set;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpStatus;
+
+class ConstraintViolationProblemResolverTest {
+
+  private ConstraintViolationProblemResolver resolver;
+
+  @BeforeEach
+  void beforeEach() {
+    resolver = new ConstraintViolationProblemResolver();
+  }
+
+  @Test
+  void givenDefaultConstructor_whenGetExceptionClass_thenReturnsConstraintViolationException() {
+    assertThat(resolver.getExceptionClass()).isEqualTo(ConstraintViolationException.class);
+  }
+
+  @Test
+  void givenExceptionWithNoViolations_whenResolve_thenReturnsBadRequestWithEmptyErrors() {
+    ConstraintViolationException ex = new ConstraintViolationException(Set.of());
+
+    Problem problem =
+        resolver
+            .resolveBuilder(ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.BAD_REQUEST)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.BAD_REQUEST.value());
+    assertThat(problem.getDetail()).isEqualTo("Validation failed");
+    assertThat(problem.getExtensionMembers()).containsEntry("errors", List.of());
+  }
+
+  @Test
+  @SuppressWarnings("unchecked")
+  void givenExceptionWithViolation_whenResolve_thenIncludesViolationInErrors() {
+    Path.Node node = mock(Path.Node.class);
+    when(node.getName()).thenReturn("email");
+    Path path = mock(Path.class);
+    when(path.iterator()).thenReturn(List.of(node).iterator());
+    ConstraintViolation<?> violation = mock(ConstraintViolation.class);
+    when(violation.getPropertyPath()).thenReturn(path);
+    when(violation.getMessage()).thenReturn("must not be blank");
+
+    ConstraintViolationException ex = new ConstraintViolationException(Set.of(violation));
+
+    Problem problem =
+        resolver
+            .resolveBuilder(ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.BAD_REQUEST)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.BAD_REQUEST.value());
+    assertThat(problem.getDetail()).isEqualTo("Validation failed");
+    assertThat((List<Violation>) problem.getExtensionValue("errors"))
+        .containsExactly(new Violation("email", "must not be blank"));
+  }
+}

problem4j-spring-web/src/test/java/io/github/problem4j/spring/web/resolver/ErrorResponseProblemResolverTest.java

@@ -0,0 +1,88 @@
+/*
+ * Copyright (c) 2025-2026 The Problem4J Authors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package io.github.problem4j.spring.web.resolver;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import io.github.problem4j.core.Problem;
+import io.github.problem4j.core.ProblemContext;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ProblemDetail;
+import org.springframework.web.ErrorResponseException;
+
+class ErrorResponseProblemResolverTest {
+
+  private ErrorResponseProblemResolver resolver;
+
+  @BeforeEach
+  void beforeEach() {
+    resolver = new ErrorResponseProblemResolver();
+  }
+
+  @Test
+  void givenDefaultConstructor_whenGetExceptionClass_thenReturnsErrorResponseException() {
+    assertThat(resolver.getExceptionClass()).isEqualTo(ErrorResponseException.class);
+  }
+
+  @Test
+  void givenErrorResponseException_whenResolve_thenCopiesStatusFromException() {
+    ErrorResponseException ex = new ErrorResponseException(HttpStatus.CONFLICT);
+
+    Problem problem =
+        resolver
+            .resolveBuilder(ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.OK)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.CONFLICT.value());
+  }
+
+  @Test
+  void givenErrorResponseExceptionWithDetail_whenResolve_thenCopiesDetailFromBody() {
+    ProblemDetail body = ProblemDetail.forStatusAndDetail(HttpStatus.BAD_REQUEST, "invalid input");
+    ErrorResponseException ex = new ErrorResponseException(HttpStatus.BAD_REQUEST, body, null);
+
+    Problem problem =
+        resolver
+            .resolveBuilder(
+                ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.INTERNAL_SERVER_ERROR)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.BAD_REQUEST.value());
+    assertThat(problem.getDetail()).isEqualTo("invalid input");
+  }
+
+  @Test
+  void givenErrorResponseException_whenResolve_thenIgnoresPassedStatus() {
+    ErrorResponseException ex = new ErrorResponseException(HttpStatus.FORBIDDEN);
+
+    Problem problem =
+        resolver
+            .resolveBuilder(
+                ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.INTERNAL_SERVER_ERROR)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.FORBIDDEN.value());
+  }
+}

problem4j-spring-web/src/test/java/io/github/problem4j/spring/web/resolver/HandlerMethodValidationProblemResolverTest.java

@@ -21,6 +21,7 @@
 
 package io.github.problem4j.spring.web.resolver;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.Mockito.mock;
 
@@ -42,6 +43,12 @@ void beforeEach() {
     handlerMethodValidationProblemResolver = new HandlerMethodValidationProblemResolver();
   }
 
+  @Test
+  void givenDefaultConstructor_whenGetExceptionClass_thenReturnsHandlerMethodValidationException() {
+    assertThat(handlerMethodValidationProblemResolver.getExceptionClass())
+        .isEqualTo(HandlerMethodValidationException.class);
+  }
+
   @Test
   void givenHandlerMethodValidationException_shouldGenerateProblem() {
     MethodValidationResult mockMethodValidationResult = mock(MethodValidationResult.class);

problem4j-spring-web/src/test/java/io/github/problem4j/spring/web/resolver/HttpMediaTypeNotAcceptableProblemResolverTest.java

@@ -0,0 +1,75 @@
+/*
+ * Copyright (c) 2025-2026 The Problem4J Authors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package io.github.problem4j.spring.web.resolver;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import io.github.problem4j.core.Problem;
+import io.github.problem4j.core.ProblemContext;
+import java.util.List;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpStatus;
+import org.springframework.web.HttpMediaTypeNotAcceptableException;
+
+class HttpMediaTypeNotAcceptableProblemResolverTest {
+
+  private HttpMediaTypeNotAcceptableProblemResolver resolver;
+
+  @BeforeEach
+  void beforeEach() {
+    resolver = new HttpMediaTypeNotAcceptableProblemResolver();
+  }
+
+  @Test
+  void
+      givenDefaultConstructor_whenGetExceptionClass_thenReturnsHttpMediaTypeNotAcceptableException() {
+    assertThat(resolver.getExceptionClass()).isEqualTo(HttpMediaTypeNotAcceptableException.class);
+  }
+
+  @Test
+  void givenHttpMediaTypeNotAcceptableException_whenResolve_thenReturnsNotAcceptableProblem() {
+    HttpMediaTypeNotAcceptableException ex = new HttpMediaTypeNotAcceptableException(List.of());
+
+    Problem problem =
+        resolver
+            .resolveBuilder(
+                ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.NOT_ACCEPTABLE)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.NOT_ACCEPTABLE.value());
+  }
+
+  @Test
+  void givenHttpMediaTypeNotAcceptableException_whenResolve_thenIgnoresPassedStatus() {
+    HttpMediaTypeNotAcceptableException ex = new HttpMediaTypeNotAcceptableException(List.of());
+
+    Problem problem =
+        resolver
+            .resolveBuilder(
+                ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.INTERNAL_SERVER_ERROR)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.NOT_ACCEPTABLE.value());
+  }
+}

problem4j-spring-web/src/test/java/io/github/problem4j/spring/web/resolver/HttpMediaTypeNotSupportedProblemResolverTest.java

@@ -0,0 +1,75 @@
+/*
+ * Copyright (c) 2025-2026 The Problem4J Authors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package io.github.problem4j.spring.web.resolver;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import io.github.problem4j.core.Problem;
+import io.github.problem4j.core.ProblemContext;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpStatus;
+import org.springframework.web.HttpMediaTypeNotSupportedException;
+
+class HttpMediaTypeNotSupportedProblemResolverTest {
+
+  private HttpMediaTypeNotSupportedProblemResolver resolver;
+
+  @BeforeEach
+  void beforeEach() {
+    resolver = new HttpMediaTypeNotSupportedProblemResolver();
+  }
+
+  @Test
+  void
+      givenDefaultConstructor_whenGetExceptionClass_thenReturnsHttpMediaTypeNotSupportedException() {
+    assertThat(resolver.getExceptionClass()).isEqualTo(HttpMediaTypeNotSupportedException.class);
+  }
+
+  @Test
+  void
+      givenHttpMediaTypeNotSupportedException_whenResolve_thenReturnsUnsupportedMediaTypeProblem() {
+    HttpMediaTypeNotSupportedException ex = new HttpMediaTypeNotSupportedException("msg");
+
+    Problem problem =
+        resolver
+            .resolveBuilder(
+                ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.UNSUPPORTED_MEDIA_TYPE)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.UNSUPPORTED_MEDIA_TYPE.value());
+  }
+
+  @Test
+  void givenHttpMediaTypeNotSupportedException_whenResolve_thenIgnoresPassedStatus() {
+    HttpMediaTypeNotSupportedException ex = new HttpMediaTypeNotSupportedException("msg");
+
+    Problem problem =
+        resolver
+            .resolveBuilder(
+                ProblemContext.create(), ex, new HttpHeaders(), HttpStatus.INTERNAL_SERVER_ERROR)
+            .build();
+
+    assertThat(problem.getStatus()).isEqualTo(HttpStatus.UNSUPPORTED_MEDIA_TYPE.value());
+  }
+}