Disable direct serialization of GPModel instance (fix #35)

Author: fsaad

Project.toml

@@ -16,6 +16,7 @@ Match = "7eb4fadd-790c-5f42-8a69-bfa0b872bfbf"
 Parameters = "d96e819e-fc66-5662-9728-84c9c7592b0a"
 Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
+Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
@@ -31,8 +32,8 @@ Statistics = "1"
 julia = "1.8"
 
 [extras]
-Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
+Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
 test = ["Test", "Serialization"]

src/api.jl

@@ -15,6 +15,7 @@
 import DataFrames
 import Distributions
 import Random
+import Serialization
 
 import Gen
 
@@ -868,6 +869,12 @@ function GPModel(m::Base.Dict{String, Any})
         m["y_transform"])
 end
 
+# Disable direct serialization.
+function Serialization.serialize(path::String, model::GPModel)
+    throw(ArgumentError("Do not use serialize(path, model:GPModel), instead use" *
+        "use serialize(path, Dict(model)."))
+end
+
 # https://juliaio.github.io/JLD2.jl/stable/customserialization/
 # struct GPModelSerialization x::Dict end
 # JLD2.writeas(::Type{GPModel}) = GPModelSerialization

test/test_serialize.jl

@@ -84,4 +84,7 @@ end
 
     end
 
+    # Ensure direct serialization fails.
+    @test_throws ArgumentError serialize("model.autogp", model1)
+
 end