performance optimisation

Author: arrxy

crates/processing_glfw/src/lib.rs

@@ -13,7 +13,7 @@ use processing_core::error::Result;
 use processing_input::{
     input_cursor_grab_mode, input_cursor_visible, input_flush, input_set_char,
     input_set_cursor_enter, input_set_cursor_leave, input_set_focus, input_set_key,
-    input_set_mouse_button, input_set_mouse_move, input_set_scroll,
+    input_set_mouse_button, input_set_mouse_move, input_set_scroll, input_window_resize,
 };
 use processing_render::surface::{MonitorWorkarea, WindowControls};
 
@@ -256,6 +256,7 @@ impl GlfwContext {
             }
         };
 
+        let mut pending_resize: Option<(i32, i32)> = None;
         for (_, event) in glfw::flush_messages(&self.events) {
             match event {
                 WindowEvent::Close => {
@@ -301,8 +302,8 @@ impl GlfwContext {
                     input_set_focus(surface, focused).unwrap();
                 }
                 WindowEvent::Size(width, height) => {
-                    processing_render::surface_resize(surface, width as u32, height as u32)
-                        .unwrap();
+                    // A drag delivers many Size events per poll; keep only the last and apply it once after the loop.
+                    pending_resize = Some((width, height));
                 }
                 _ => {}
             }
@@ -313,6 +314,12 @@ impl GlfwContext {
             return false;
         }
 
+        // Apply the coalesced resize once, the WindowResized message and Window change are processed this poll.
+        if let Some((width, height)) = pending_resize {
+            input_window_resize(surface, width as f32, height as f32).unwrap();
+            processing_render::surface_resize(surface, width as u32, height as u32).unwrap();
+        }
+
         let Ok(_) = input_flush() else {
             return false;
         };

crates/processing_input/src/lib.rs

@@ -8,7 +8,7 @@ use bevy::input::mouse::{
 };
 use bevy::input::touch::TouchPhase;
 use bevy::prelude::*;
-use bevy::window::CursorMoved;
+use bevy::window::{CursorMoved, WindowResized};
 
 use processing_core::app_mut;
 use processing_core::error;
@@ -342,3 +342,14 @@ pub fn input_mouse_scrolled() -> error::Result<bool> {
         Ok(d.x != 0.0 || d.y != 0.0)
     })
 }
+
+pub fn input_window_resize(surface: Entity, width: f32, height: f32) -> error::Result<()> {
+    app_mut(|app| {
+        app.world_mut().write_message(WindowResized {
+            window: surface,
+            width,
+            height,
+        });
+        Ok(())
+    })
+}

crates/processing_render/src/graphics.rs

@@ -22,7 +22,7 @@ use bevy::{
         sync_world::MainEntity,
         view::ViewTarget,
     },
-    window::{WindowRef, WindowResized},
+    window::WindowRef,
 };
 
 use crate::{
@@ -260,7 +260,6 @@ pub fn sync_to_surface(
     mut graphics_query: Query<(&mut Graphics, &RenderTarget)>,
     windows: Query<&Window, (With<Surface>, Changed<Window>)>,
     render_device: Res<RenderDevice>,
-    mut resize_messages: MessageWriter<WindowResized>,
 ) {
     for (mut graphics, target) in graphics_query.iter_mut() {
         let RenderTarget::Window(WindowRef::Entity(surface_entity)) = *target else {
@@ -274,12 +273,6 @@ pub fn sync_to_surface(
         if graphics.size.width == physical_w && graphics.size.height == physical_h {
             continue;
         }
-        //winit plugin disabled, so WindowResized is never triggered automatically
-        resize_messages.write(WindowResized {
-            window: surface_entity,
-            width: window.width(),
-            height: window.height(),
-        });
         graphics.size = Extent3d {
             width: physical_w,
             height: physical_h,