Skip to content

Commit bc3ecc6

Browse files
committed
Merge branch 'release-2.20.2' into release
2 parents 29296a6 + 935f5b7 commit bc3ecc6

File tree

11 files changed

+19238
-25569
lines changed

11 files changed

+19238
-25569
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
1-
Fixes #issue-number
1+
### Context or Issue Number:
2+
<!-- Please add the issue this relates to if one is available. Otherwise please describe the current state of the codebase and what this PR attempts to fix. -->
23

3-
Changes:
4+
### Demo:
5+
<!-- Please add a screenshot for UI related changes -->
46

5-
I have verified that this pull request:
7+
### Changes:
8+
<!-- Summarise your changes -->
9+
10+
### I have verified that this pull request:
611

712
* [ ] has no linting errors (`npm run lint`)
813
* [ ] has no test errors (`npm run test`)

client/styles/abstracts/_placeholders.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@
3434

3535
%icon-toast{
3636
@include themify() {
37-
color: $toast-text-color
37+
color: getThemifyVariable('toast-text-color');
3838
& g, & path {
39-
fill: $toast-text-color
39+
fill: getThemifyVariable('toast-text-color');
4040
}
4141
&:hover {
42-
color: getThemifyVariable('icon-toast-hover-color');
42+
color: getThemifyVariable('toast-text-color');
4343
& g, & path {
4444
opacity: 1;
45-
fill: getThemifyVariable('icon-toast-hover-color');
45+
fill: getThemifyVariable('toast-text-color');
4646
}
4747
}
4848
}

client/styles/abstracts/_variables.scss

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ $themes: (
5555
modal-border-color: $middle-light,
5656
icon-color: $middle-gray,
5757
icon-hover-color: $darker,
58-
icon-toast-hover-color: $lightest,
5958
shadow-color: rgba(0, 0, 0, 0.16),
6059
console-background-color: $light,
6160
console-input-background-color: $lightest,
@@ -130,6 +129,9 @@ $themes: (
130129
admonition-border: #22C8ED,
131130
admonition-background: #E4F8FF,
132131
admonition-text: #075769,
132+
133+
toast-background-color: $medium-dark,
134+
toast-text-color: $lightest,
133135
),
134136
dark: (
135137
logo-color: $p5js-pink,
@@ -156,7 +158,6 @@ $themes: (
156158
modal-border-color: $middle-dark,
157159
icon-color: $middle-light,
158160
icon-hover-color: $lightest,
159-
icon-toast-hover-color: $lightest,
160161
shadow-color: rgba(0, 0, 0, 0.16),
161162
console-background-color: $dark,
162163
console-input-background-color: $darker,
@@ -229,6 +230,9 @@ $themes: (
229230
admonition-border: #22C8ED,
230231
admonition-background: #105A7F,
231232
admonition-text: #FFFFFF,
233+
234+
toast-background-color: $medium-light,
235+
toast-text-color: $dark,
232236
),
233237
contrast: (
234238
logo-color: $yellow,
@@ -255,7 +259,6 @@ $themes: (
255259
modal-border-color: $middle-dark,
256260
icon-color: $medium-light,
257261
icon-hover-color: $yellow,
258-
icon-toast-hover-color: $yellow,
259262
shadow-color: rgba(0, 0, 0, 0.16),
260263
console-background-color: $dark,
261264
console-input-background-color: $darker,
@@ -328,9 +331,9 @@ $themes: (
328331
admonition-border: #22C8ED,
329332
admonition-background: #000000,
330333
admonition-text: #ffffff,
331-
)
332-
);
333334

334-
$toast-background-color: $medium-dark;
335-
$toast-text-color: $lightest;
335+
toast-background-color: $medium-light,
336+
toast-text-color: $darker,
336337

338+
)
339+
);

client/styles/components/_toast.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
@use "sass:math";
22

33
.toast {
4-
background-color: $toast-background-color;
5-
color: $toast-text-color;
4+
@include themify() {
5+
color: getThemifyVariable('toast-text-color');
6+
background-color: getThemifyVariable('toast-background-color');
7+
}
68
padding: #{math.div(10, $base-font-size)}rem;
79
position: fixed;
810
top: 0;

common/p5Versions.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ export const currentP5Version = '1.11.11'; // Don't update to 2.x until 2026
55
// JSON.stringify([...document.querySelectorAll('._132722c7')].map(n => n.innerText), null, 2)
66
// TODO: use their API for this to grab these at build time?
77
export const p5Versions = [
8-
{ version: '2.2.0', label: '(Beta)' },
8+
{ version: '2.2.1', label: '(Beta)' },
9+
'2.2.0',
910
'2.1.2',
1011
'2.1.1',
1112
'2.0.5',

contributor_docs/s3_configuration.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
}
2222
]
2323
```
24-
3. In permissions, add the following bucket policy. Change "YOUR_BUCKET_NAME" to reflect name of the S3 bucket.
24+
3. Uncheck "Block all public access" under "Block public access (bucket settings)".
25+
4. In permissions, add the following bucket policy. Change "YOUR_BUCKET_NAME" to reflect name of the S3 bucket.
2526
```
2627
{
2728
"Version": "2008-10-17",
@@ -39,7 +40,6 @@
3940
]
4041
}
4142
```
42-
4. Uncheck "Block all public access" under "Block public access (bucket settings)".
4343
5. Under "Object Ownership", check "ACLs enabled" and set "Object Ownership" to "Object writer"
4444
6. Locate your AWS key and Secret Key. You can find this in the top AWS navigation under your name -> Security Credentials.
4545
7. Update the following lines to your .env file:
@@ -48,6 +48,7 @@ AWS_ACCESS_KEY={AWS_ACCESS_KEY}
4848
AWS_REGION={S3_BUCKET_REGION}
4949
AWS_SECRET_KEY={AWS_SECRET_KEY}
5050
S3_BUCKET={S3_BUCKET_NAME}
51+
S3_BUCKET_URL_BASE=https://{S3_BUCKET_NAME}.s3.{S3_BUCKET_REGION}.amazonaws.com/
5152
```
5253

5354
If your S3 bucket is in the US East (N Virginia) region (us-east-1), you'll

0 commit comments

Comments
 (0)