Skip to content

Add margin-left to sort button in sketches page#3436

Merged
raclim merged 3 commits into
processing:developfrom
jeanetteandrews:bugfix/sort-button
Apr 10, 2025
Merged

Add margin-left to sort button in sketches page#3436
raclim merged 3 commits into
processing:developfrom
jeanetteandrews:bugfix/sort-button

Conversation

@jeanetteandrews

@jeanetteandrews jeanetteandrews commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

Fixes #3432

Changes:
Added margin-left: #{math.div(5, $base-font-size)}rem; to .sketch-list__sort-button svg in _sketch-list.scss for better spacing of the sort button on the 'Sketches' page.

sort-button


This ensures consistency with the existing code in _nav.scss, where the same margin is applied to .nav__item-header-triangle on the 'Editor' page.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome

welcome Bot commented Apr 6, 2025

Copy link
Copy Markdown

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim raclim added Bug Error or unexpected behaviors Area:CSS For styling or layout issues handled with CSS/SASS labels Apr 10, 2025

@raclim raclim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for much for fixing this @jeanetteandrews, this looks great to me!

@raclim raclim merged commit 8bf9cb4 into processing:develop Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area:CSS For styling or layout issues handled with CSS/SASS Bug Error or unexpected behaviors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styling bug: Spacing of sorting arrows on sketches and collections page

2 participants