Skip to content

[#3434] Remove left padding on overlay close button#3439

Merged
raclim merged 2 commits into
processing:developfrom
JoaoJoaoVF:fix/overlay-close-padding
Apr 10, 2025
Merged

[#3434] Remove left padding on overlay close button#3439
raclim merged 2 commits into
processing:developfrom
JoaoJoaoVF:fix/overlay-close-padding

Conversation

@JoaoJoaoVF

Copy link
Copy Markdown
Contributor

Adjusted the CSS to remove the extra left padding on the close button. This ensures that the active box is centered around the 'X' when clicked.

  • Removed left padding value from the padding property
  • Verified alignment in both desktop and responsive view

Fixes #3434

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Adjusted the CSS to remove the extra left padding on the close button.
This ensures that the active box is centered around the 'X' when clicked.

- Removed left padding value from the padding property
- Verified alignment in both desktop and responsive view
@welcome

welcome Bot commented Apr 6, 2025

Copy link
Copy Markdown

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim raclim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good to me, thanks for your work on this!

@raclim raclim merged commit 414dd00 into processing:develop Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings Closing "X" active box misalignment

2 participants