Fix: Prevent duplicate file renaming in sidebar#3455
Merged
Conversation
…js-web-editor into Branch_Kamakshi
Contributor
Author
|
@raclim Currently, if a user tries to rename a file to a name that already exists in the same directory, the name simply reverts to the original without any visual feedback. No error message or dialog is shown. |
raclim
approved these changes
Apr 17, 2025
Collaborator
raclim
left a comment
There was a problem hiding this comment.
Thanks for finding these issues and suggesting these fixes for them! I really like the renaming on double-click implementation!
In terms of giving some sort of visual feedback or warning—I think maybe we can try what you currently have here for now and see how folks respond. Thanks so much again for your work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3454 and #3456
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123