Skip to content

fix: Inconsistent Screen Reader Announcement for Word Wrap Toggle Button in Settings#3476

Merged
raclim merged 6 commits into
processing:developfrom
SalmanNajah:fix/word-wrap-toggle-3475
May 16, 2025
Merged

fix: Inconsistent Screen Reader Announcement for Word Wrap Toggle Button in Settings#3476
raclim merged 6 commits into
processing:developfrom
SalmanNajah:fix/word-wrap-toggle-3475

Conversation

@SalmanNajah
Copy link
Copy Markdown
Contributor

@SalmanNajah SalmanNajah commented May 10, 2025

Fixes #3475

Changes:

  • Previously, when focusing on the toggle button (On/Off), the screen reader would announce "Line wrap is enabled/disabled", which differed from the expected terminology.
  • This has been updated so the screen reader now announces “Word Wrap is On/Off”, making it clearer and consistent with the visible label.
video-demo.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link
Copy Markdown

welcome Bot commented May 10, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

yugalkaushik
yugalkaushik approved these changes May 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SalmanNajah
Copy link
Copy Markdown
Contributor Author

SalmanNajah commented May 12, 2025

Hi @raclim, Could you please review this PR?

raclim
raclim approved these changes May 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well, thanks so much for your work on this!

@raclim raclim merged commit ee16859 into processing:develop May 16, 2025
1 check passed
@SalmanNajah SalmanNajah deleted the fix/word-wrap-toggle-3475 branch May 18, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

+1 more reviewer

@yugalkaushik yugalkaushik yugalkaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent Screen Reader Announcement for Word Wrap Toggle Button

3 participants

@SalmanNajah @raclim @yugalkaushik