Converts CM5 into CM6#3500
Merged
raclim merged 14 commits intodevelop-codemirror-v6from Jul 11, 2025
Merged
Conversation
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-3cdba4e141 |
af10dc9 to
0cf467a
Compare
raclim
reviewed
Jul 10, 2025
Collaborator
raclim
left a comment
There was a problem hiding this comment.
Thanks so much for your work on this—I think this overall feels really solid!
I did some manual testing, and everything seems to function as expected besides the elements that you've already noted as TODOs! I just had a small question in codemirror.js, but aside from that that this feels like it's in a great place to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #issue-number
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123