Skip to content

Converts CM5 into CM6#3500

Merged
raclim merged 14 commits intodevelop-codemirror-v6from
connie-codemirror-upgrade
Jul 11, 2025
Merged

Converts CM5 into CM6#3500
raclim merged 14 commits intodevelop-codemirror-v6from
connie-codemirror-upgrade

Conversation

@khanniie
Copy link
Copy Markdown
Member

@khanniie khanniie commented May 30, 2025

Fixes #issue-number

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com
Copy link
Copy Markdown

release-com Bot commented May 30, 2025

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-3cdba4e141

@khanniie khanniie force-pushed the connie-codemirror-upgrade branch from af10dc9 to 0cf467a Compare July 6, 2025 22:43
@khanniie khanniie changed the title [WIP] Converts CM5 into CM6 Converts CM5 into CM6 Jul 7, 2025
@khanniie khanniie requested a review from raclim July 7, 2025 15:44
Copy link
Copy Markdown
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this—I think this overall feels really solid!

I did some manual testing, and everything seems to function as expected besides the elements that you've already noted as TODOs! I just had a small question in codemirror.js, but aside from that that this feels like it's in a great place to me!

Comment thread client/modules/IDE/components/Editor/codemirror.js
@khanniie khanniie requested a review from raclim July 10, 2025 06:42
Copy link
Copy Markdown
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! :)

@raclim raclim merged commit d7cd4f5 into develop-codemirror-v6 Jul 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants