i18n(de): Update 'Settings' and 'SubmitSaveAllSettings' Translation Keys in German Locale#3644
i18n(de): Update 'Settings' and 'SubmitSaveAllSettings' Translation Keys in German Locale#3644raclim merged 3 commits intoprocessing:developfrom ajinkyap9:i18n-sync-german-locale-3510
Conversation
- Replace 'SubmitSaveAllSettings' with 'SaveAccountDetails' in German locale - Update 'Settings' from 'Account Einstellungen' to 'Mein Konto' in AccountView - Aligns German translations with updated English UI terminology Progress towards #3510
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
@figuraetymologica Thanks again for your help with the German translation on the recent banner! If you have a moment, would you be able to give these translations a quick look to confirm if they’re correct? |
|
Glad I was able to help and no problem at all! The translations are looking overall sound. My input would be that Kontoeinstellungen speichern might be more intuitive/appropriate than Kontodetails speichern. Kontodetails is reminiscent of banking (if I ask someone for their Kontodetails I’m asking for their bank account details) and googling the word overwhelmingly yields results associated with online banking. Then again, it is shorter and in the context of editing one‘s account information communicates the intended meaning. :-) (I hope I didn‘t overdo it, I’m not trying to be nitpicky 🙂 |
|
@figuraetymologica Thanks a lot for the valuable feedback! |
Replaced "Kontodetails speichern" with "Kontoeinstellungen speichern"
raclim
left a comment
There was a problem hiding this comment.
Thank you so much @figuraetymologica for your insight! I don't think it was nitpicky at all—the context is extremely helpful, especially as someone who does not know German! 😂
Thank you again @ajinkya22-dev for putting in this fix and for your quick follow up! I'm going to merge this in!
Progress towards #3510
Changes:
The UI should now display the correct text in German.
This solution is implemented with reference to the context and discussions in issue #3509.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #3510