Skip to content

Move donate-page banner into a footer landmark region [2.0] #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksen0 merged 5 commits into from
Mar 14, 2026
Merged

Move donate-page banner into a footer landmark region [2.0] #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21eae32
Add Hindi translation for Variables and Change tutorial
aashu2006 Mar 3, 2026
8522b1d
Fix "hide banner" button not contained within any landmark region
tsengwoody Aug 4, 2025
d21b13b
Revert "Fix "hide banner" button not contained within any landmark re…
coseeian Jan 1, 2026
35bcf57
feat: wrap banner in it's own footer landmark
coseeian Jan 1, 2026
cacae98
feat: update sticky footer aria-label
coseeian Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Banner/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ const { Content } = await entry.render();
const { link, title } = entry.data;
---

<div class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title}>
<footer class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title} aria-label="sticky">
<a class="banner-content" href={link} target="_blank">
<Content />
</a>
<button id="hideBanner" aria-label="Hide banner"><Icon kind="close" /></button>
</div>
</footer>

<script>
const banner = document.querySelector('.banner');
Expand Down
Loading
Loading