beta_deploy: have astro build action use node 22#1241
Merged
ksen0 merged 1 commit intoprocessing:2.0from Mar 16, 2026
Merged
Conversation
Contributor
Author
|
Testing update:
|
Contributor
|
@nbogie Wondering if it's useful to also specify the Node version in the package.json? |
Contributor
Author
|
Hi @doradocodes !
Yes, that's done in the recently merged #1234 There's some more detail in the main issue: #1233 Thank you for recommending it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #1233
Changes beta_deploy.yml build-deploy job to explicitly tell the astro build action which version of node.js to use.
This is necessary because that astro build action will do an
npm installwhich will fail if it's not at least on node 22.The action's documentation is here (for v2 of the action). (I note v5 of the action already defaults to run on node.js v24, but it's better we state it explicitly so maintainers are aware of what's being used and can easily control it).