Skip to content

beta_deploy: have astro build action use node 22#1241

Merged
ksen0 merged 1 commit intoprocessing:2.0from
nbogie:nb-set-node-version-in-deploy-build
Mar 16, 2026
Merged

beta_deploy: have astro build action use node 22#1241
ksen0 merged 1 commit intoprocessing:2.0from
nbogie:nb-set-node-version-in-deploy-build

Conversation

@nbogie
Copy link
Copy Markdown
Contributor

@nbogie nbogie commented Mar 16, 2026

Addresses: #1233

Changes beta_deploy.yml build-deploy job to explicitly tell the astro build action which version of node.js to use.

This is necessary because that astro build action will do an npm install which will fail if it's not at least on node 22.

The action's documentation is here (for v2 of the action). (I note v5 of the action already defaults to run on node.js v24, but it's better we state it explicitly so maintainers are aware of what's being used and can easily control it).

@nbogie
Copy link
Copy Markdown
Contributor Author

nbogie commented Mar 16, 2026

Testing update:

  1. on my own github, tested a simplification of this beta_deploy.yml which skips the final netlify deploy. It correctly allows the astro build (v2) to run successfully on node 22.
  2. tried without the node-version stipulation, and it breaks as expected (it is defaulting to node 20 and noting the mismatch against what package.json and .npmrc dictate)
  3. Successfully tested the full deploy to netlify, too. (well, it built and deployed ok then failed because it didn't have perms to update my repo. unrelated.)

@doradocodes
Copy link
Copy Markdown
Contributor

@nbogie Wondering if it's useful to also specify the Node version in the package.json?

@nbogie
Copy link
Copy Markdown
Contributor Author

nbogie commented Mar 16, 2026

Hi @doradocodes !

specify the Node version in the package.json?

Yes, that's done in the recently merged #1234

There's some more detail in the main issue: #1233

Thank you for recommending it!

@ksen0 ksen0 merged commit 1a7cb8b into processing:2.0 Mar 16, 2026
4 checks passed
@nbogie nbogie deleted the nb-set-node-version-in-deploy-build branch March 16, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants