Skip to content

fix: adjust landscape hero images to fill header on mobile (#1222) #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doradocodes merged 1 commit into from
Mar 16, 2026
Merged

fix: adjust landscape hero images to fill header on mobile (#1222) #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/PageHeader/HomePage.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const { config } = Astro.props;
im.linkTarget ?
<a href={im.linkTarget} class={`max-lg:flex-1 max-lg:min-h-0 hero-image-container ${i > 0 ? "hidden" : ""}`}>
<Image
containerClass={"relative"}
containerClass={"relative h-full"}
class={"hero-image"}
aspectRatio="none"
src={im.image}
Expand Down Expand Up @@ -80,4 +80,4 @@ const { config } = Astro.props;
}
}
});
</script>
</script>
20 changes: 4 additions & 16 deletions styles/global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ code {
background-color: var(--bg-gray-80);
border-radius: 20px;
padding: 0 var(--spacing-xxs);

.dark-theme &:not(.code-box) {
color: var(--type-black);
}
Expand All @@ -231,18 +230,16 @@ section,
h2,
.text-h2 {
margin-top: var(--gutter-md);
margin-bottom: var(--spacing-md);
margin-bottom: 0px;
}

h2,
.text-h2,
h3,
text-h3 {

&,
&>* {
& > * {
scroll-margin-top: var(--gutter-md);

@media (min-width: $breakpoint-tablet) {
scroll-margin-top: var(--gutter-sm);
}
Expand Down Expand Up @@ -272,7 +269,6 @@ section,
overflow-x: auto;

border-radius: 20px;

@media (max-width: $breakpoint-tablet) {
border-radius: 10px;
}
Expand Down Expand Up @@ -474,15 +470,11 @@ th {
border-bottom-width: 1px;
border-top-width: 1px;

// Fix #1061: On mobile/tablet (< 1024px) the outer wrapper is a flex column
// and the image container is flex-1. height: 100% fills the remaining header
// space exactly — no overflow into the h1 below, no gap on tall devices.
@media (max-width: #{$breakpoint-laptop - 1px}) {
height: 100%;
max-height: none;
min-height: 180px;
}

@media (min-width: $breakpoint-tablet) {
left: calc(-1 * var(--spacing-lg));
width: calc(100% + var(--spacing-lg) * 2);
Expand All @@ -496,7 +488,6 @@ hr.full-bleed {
left: -2.5rem;
width: calc(100% + 5rem);
max-width: calc(100% + 5rem);

@media (min-width: $breakpoint-tablet) {
left: calc(-1 * var(--spacing-lg));
width: calc(100% + var(--spacing-lg) * 2);
Expand All @@ -516,13 +507,10 @@ input[type="search"]::-webkit-search-results-decoration {
.no-scrollbar::-webkit-scrollbar {
display: none;
}

/* Hide scrollbar for IE, Edge and Firefox */
.no-scrollbar {
-ms-overflow-style: none;
/* IE and Edge */
scrollbar-width: none;
/* Firefox */
-ms-overflow-style: none; /* IE and Edge */
scrollbar-width: none; /* Firefox */
}

/** SPECIAL ELEMENTS **/
Expand Down
Loading