Add missing Korean UI translations #1267
Conversation
|
Hi @hana-cho, if you have a bit of time, would you be able to review this please? |
eupthere
left a comment
There was a problem hiding this comment.
Thanks so much for your contribution!
I’ve left a few suggestions to help make some phrasing sound a bit more natural and consistent, but overall this is a solid contribution. Thanks again for taking the time to work on this!
Also, this is my first time reviewing in this repository, so if you have any feedback on my review, I’d really appreciate it!
| Related Examples: 관련 예제 | ||
| Show Code: 코드 보기 | ||
| Donate to p5.js: p5.js에 기부하기 | ||
| Donate to Processing Foundation: Processing Foundation에 기부하기 |
There was a problem hiding this comment.
I don't see this field in src/content/ui/en.yaml. Is it needed?
There was a problem hiding this comment.
I do see it in other localization files (https://github.com/processing/p5.js-website/blob/main/src/content/ui/zh-Hans.yaml#L44) and in one of the layout files (
)You can see in the file the usage is t("Donate to Processing Foundation") which will default to the text provided, or attempt localization. So if english translation looks like it's missing it would still work.
| Donate to Processing Foundation: Processing Foundation에 기부하기 | ||
| Download p5.js: p5.js 다운로드 | ||
| No Results: 검색 결과가 없습니다. | ||
| No alt text: 대체 텍스트 없음 |
There was a problem hiding this comment.
Would it make sense for the translation for No alt text to also be a full sentence (i.e similar to No Results)?
There was a problem hiding this comment.
I agree it could be improved with more consistency. Personally No alt text translation seems to match the concise tone better.
There is no result: 검색 결과가 없습니다.
There is no alternative text: 대체 텍스트가 없습니다.
No Results: 검색 결과 없음
No alt text: 대체 텍스트 없음
|
@eupthere Thanks for the detailed review, these sound much more natural. Committing all of them. |
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Addresses issue #1207
I looked into why the korean "Jump to" menu was showing chinese and found that ko.yaml was only translating 6 out of 17 referenceCategories modules. The rest were missing entirely so the site was falling back to wrong text.
I added all the missing module and submodule entries plus some other keys that zh-Hans and en had but ko didn't (exampleCategories, libraryCategories, callout titles etc).
Just a quick heads up i don't speak korean so I cross referenced the chinese simplified file and looked up standard computing terms in Korean. Would appreciate a native speaker reviewing before this gets merged.