Skip to content

Add Korean translations for contact, copyright, and download pages#1407

Merged
ksen0 merged 7 commits into
processing:mainfrom
star11293:add-korean-text-detail-translations
May 26, 2026
Merged

Add Korean translations for contact, copyright, and download pages#1407
ksen0 merged 7 commits into
processing:mainfrom
star11293:add-korean-text-detail-translations

Conversation

@star11293
Copy link
Copy Markdown
Contributor

@star11293 star11293 commented May 23, 2026

Adresses: #1408

Summary

Adds Korean (ko) translations for three previously untranslated text-detail pages:

  • src/content/text-detail/ko/contact.mdx
  • src/content/text-detail/ko/copyright.mdx
  • src/content/text-detail/ko/download.mdx

The text-detail/ko/ directory previously only had about.mdx, code-of-conduct.mdx, and donate.mdx. This brings Korean coverage closer to parity with the other supported languages and continues the Korean localization work started in #1267.

Translation conventions

Followed the patterns already established in the existing Korean files:

  • Formal polite Korean (-합니다 style) throughout
  • Proper nouns kept in English (Processing Foundation, Free Software Foundation, Bocoup, person names) to match donate.mdx
  • p5.js, p5.sound, p5.min.js left as-is
  • UI terminology matched to src/content/ui/ko.yaml: Download → 다운로드, Reference → 레퍼런스, Examples → 예제, Libraries → 라이브러리
  • Editor → 에디터 (matches usage in existing about.mdx)
  • All component imports, link targets, and markdown structure preserved 1:1 with the English source

Notes for reviewers

A few specific choices that would benefit from native-speaker review:

  • Title for copyright.mdx: chose 저작권 및 감사의 말 for "Copyright and Acknowledgement". Open to 감사 인사 or 감사의 글 if those read better in this context.
  • Went with 라이선스 (the National Institute of Korean Language standard) over 라이센스. No prior usage in the repo to anchor to.
  • Person names left in English rather than romanized, to match existing Korean files.

If anything reads weird in Korean just tell me and I'll fix it.

Adds Korean (ko) translations for three previously untranslated
text-detail pages, following the conventions used in the existing
Korean files (about.mdx, code-of-conduct.mdx, donate.mdx).

- Formal polite Korean throughout
- Proper nouns kept in English (Processing Foundation, person names)
- Terminology matches src/content/ui/ko.yaml
- Component imports, links, and structure preserved 1:1 with EN
@doradocodes doradocodes linked an issue May 25, 2026 that may be closed by this pull request
@doradocodes
Copy link
Copy Markdown
Contributor

Hi @star11293, thanks for the work on this! In the future, we ask that you wait to be assigned before working on any issues. Please see the community guidelines for more information.

@eupthere@hana-cho could you please review these translations?

Copy link
Copy Markdown
Contributor

@eupthere eupthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the translations! I suggested a few minor changes to make some sentences sound more natural

Comment thread src/content/text-detail/ko/copyright.mdx Outdated
Comment thread src/content/text-detail/ko/copyright.mdx Outdated
Comment thread src/content/text-detail/ko/download.mdx Outdated
Comment thread src/content/text-detail/ko/download.mdx Outdated
Comment thread src/content/text-detail/ko/download.mdx Outdated
Comment thread src/content/text-detail/ko/download.mdx Outdated
star11293 and others added 6 commits May 26, 2026 02:28
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
Co-authored-by: eupthere <eupthere@gmail.com>
@ksen0
Copy link
Copy Markdown
Member

ksen0 commented May 26, 2026

Thank everyone!

@ksen0 ksen0 merged commit 2738278 into processing:main May 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Korean translations for missing text-detail pages

4 participants