Update tutorial snippet to pass proper varying from vertex shader to#1439
Merged
davepagurek merged 2 commits intoJun 11, 2026
Conversation
Contributor
Author
|
@doradocodes @Nwakaego-Ego @davepagurek Follow-up PR to our previous discussion here -> #1122. I also noticed that the code looks the same in the |
davepagurek
approved these changes
Jun 11, 2026
davepagurek
left a comment
davepagurek
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1437
Description
This is a follow-up PR to this PR #1122 (review) where it was mentioned that the same fix should be applied to the 2.0 branch.
Changes
vVertexColorvarying in the tutorial snippet for "Varyings: Passing data from vertex to fragment shader" and instead passvTexCoordvarying to the fragment shader.