Bug fixes for Shader API#7675
Merged
Merged
Conversation
davepagurek
reviewed
Mar 26, 2025
davepagurek
reviewed
Mar 27, 2025
| shouldUseTemporaryVariable() { | ||
| if (this.swizzleChanged) { return true; } | ||
| if (this.type === 'sampler2D') { return false; } | ||
| return true; |
Contributor
There was a problem hiding this comment.
Just checking, did you want to leave this in?
…function signatures allow for vectors as gentype + float
…from float nodes, and reinforce that components are nodes on toGLSL()
…e converted to FES later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
I fixed several bugs I found in the Shader API. These include:
dynamicNode(), i.e. if they were Identifiers.uniformVector2(() => [val1, val2])was broken as the previous implementation was wrapping vector uniforms into arrays.5.000xinput.color = 1. This was inconsistent with hooks which expect a built in type such asvec4.As a note @davepagurek now that 2 and 4 above are fixed,
[]as a vector constructor is now complete. Point 2 is also compatible with the current hooks andsetUniform()which do take arrays to represent vecs.