-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Resolves #8278 #8328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Resolves #8278 #8328
Changes from 23 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1be7b20
implemented first 10 getters
dhowe ae9af30
more getters
dhowe 8f7a431
complete first set of getters
dhowe 039ef43
update parameter json, add tests for getters
dhowe ece3986
add bezierOrder and splineProperties to tests
dhowe 8d43489
Merge branch 'dev-2.0' into ticket8278
dhowe 255af5a
remove getters for matrix transforms: shear, rotate, translate, scale
dhowe f26eff6
remove translate, rotate, scale from getter tests
dhowe be4de98
re-implemented tint, plus textureWrap and textureMode
dhowe f87df11
update fes data
dhowe 6d2734c
Merge branch 'dev-2.0' into ticket8278
dhowe 67bd05b
fix to #8469 in dev-2.0
dhowe 0f82b9b
Revert "fix to #8469 in dev-2.0"
dhowe 0f67aa4
Merge branch 'processing:dev-2.0' into dev-2.0
dhowe af7b67a
Merge branch 'dev-2.0' into ticket8278
dhowe 3559fad
fix to bug with color in tint
dhowe 4c51317
merge from dev2.0
dhowe d22cd36
using 255 range for tint in shaders
dhowe f9460f4
fix tint-related gl tests
dhowe 2b30d89
Merge branch 'dev-2.0' into ticket8278
dhowe 19c6851
first pass at updating jsdocs for setters
dhowe 85d6ccc
updated inline jsdocs for all setters that have them
dhowe 1a408af
remove no-longer used decomposeMatrix function
dhowe acc319a
fixes from reviewer
dhowe 3d4d45e
fix to tint argument handling
dhowe 227c6a3
Merge branch 'dev-2.0' into ticket8278
dhowe 0bf343a
fix to tint in Renderer3D
dhowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -724,7 +724,7 @@ class Color { | |
| if(!Array.isArray(v)){ | ||
| return [0, v]; | ||
| }else{ | ||
| return v | ||
| return v; | ||
| } | ||
| }); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.