Skip to content

fix textToModel regression for space characters #8429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perminder-17 merged 2 commits into from
Jan 20, 2026
Merged

fix textToModel regression for space characters #8429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5670e2c
fix textToModel to return empty geometry for space characters
skyash-dev Jan 20, 2026
32b42e3
Merge branch 'dev-2.0' into fix-textToModel-empty-glyph
perminder-17 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/type/p5.Font.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,10 @@ export class Font {
const extrude = options?.extrude || 0;

let contours = this.textToContours(str, x, y, width, height, options);
if (!contours || contours.length === 0) {
return new p5.Geometry();
}

// Step 2: build base flat geometry - single shape
const geom = this._pInst.buildGeometry(() => {
const prevValidateFaces = this._pInst._renderer._validateFaces;
Expand Down
Loading