Refactor p5.Vector to prioritize smaller dimension in binary operations on mismatched-size vectors

src/core/main.js

@@ -50,7 +50,7 @@ class p5 {
   constructor(sketch, node) {
     // Apply addon defined decorations
     if(p5.decorations.size > 0){
-      decorateClass(p5, p5.decorations);
+      decorateClass(p5, p5.decorations, 'p5', p5);
       p5.decorations.clear();
     }
 
@@ -520,7 +520,7 @@ function createBindGlobal(instance) {
 }
 
 // Generic function to decorate classes
-function decorateClass(Target, decorations, path){
+function decorateClass(Target, decorations, path, p5){
   path ??= Target.name;
   // Static properties
   for(const key in Target){
@@ -532,7 +532,8 @@ function decorateClass(Target, decorations, path){
             const result = decorator(Target[key], {
               kind: 'method',
               name: key,
-              static: true
+              static: true,
+              p5
             });
             if(result){
               Object.defineProperty(Target, key, {
@@ -545,7 +546,8 @@ function decorateClass(Target, decorations, path){
             const result = decorator(undefined, {
               kind: 'field',
               name: key,
-              static: true
+              static: true,
+              p5
             });
             if(result && typeof result === 'function'){
               Target[key] = result(Target[key]);
@@ -555,7 +557,7 @@ function decorateClass(Target, decorations, path){
       }
 
       if(typeof Target[key] === 'function' && Target[key].prototype){
-        decorateClass(Target[key], decorations, `${path}.${key}`);
+        decorateClass(Target[key], decorations, `${path}.${key}`, p5);
       }
     }
   }
@@ -570,7 +572,8 @@ function decorateClass(Target, decorations, path){
             const result = decorator(Target.prototype[member], {
               kind: 'method',
               name: member,
-              static: false
+              static: false,
+              p5
             });
             if(result) {
               Object.defineProperty(Target.prototype, member, {
@@ -588,7 +591,8 @@ function decorateClass(Target, decorations, path){
               const result = decorator(undefined, {
                 kind: 'field',
                 name: member,
-                static: false
+                static: false,
+                p5
               });
               Object.defineProperty(Target.prototype, member, {
                 enumerable: true,
@@ -602,12 +606,14 @@ function decorateClass(Target, decorations, path){
               const getterResult = decorator(get, {
                 kind: 'getter',
                 name: member,
-                static: false
+                static: false,
+                p5
               });
               const setterResult = decorator(set, {
                 kind: 'setter',
                 name: member,
-                static: false
+                static: false,
+                p5
               });
               Object.defineProperty(Target.prototype, member, {
                 enumerable: true,

src/image/p5.Image.js

@@ -31,6 +31,9 @@ class Image {
     this.pixels = [];
   }
 
+  // This will get overwritten when exported as part of p5.
+  _friendlyError(_e) {}
+
   /**
    * Gets or sets the pixel density for high pixel density displays.
    *
@@ -1605,7 +1608,7 @@ class Image {
         props.displayIndex = index;
         this.drawingContext.putImageData(props.frames[index].image, 0, 0);
       } else {
-        p5._friendlyError(
+        this._friendlyError(
           'Cannot set GIF to a frame number that is higher than total number of frames or below zero.',
           'setFrame'
         );
@@ -2105,6 +2108,8 @@ function image(p5, fn){
    */
   p5.Image = Image;
 
+  Image.prototype._friendlyError = p5._friendlyError;
+
   /**
    * The image's width in pixels.
    *

src/math/index.js

@@ -4,6 +4,7 @@ import random from './random.js';
 import trigonometry from './trigonometry.js';
 import math from './math.js';
 import vector from './p5.Vector.js';
+import vectorValidation from './patch-vector.js';
 
 export default function(p5){
   p5.registerAddon(calculation);
@@ -12,4 +13,5 @@ export default function(p5){
   p5.registerAddon(trigonometry);
   p5.registerAddon(math);
   p5.registerAddon(vector);
+  p5.registerAddon(vectorValidation);
 }

src/math/math.js

@@ -38,7 +38,7 @@ function math(p5, fn) {
    * <a href="#/p5.Vector">p5.Vector</a> class.
    *
    * @method createVector
-   * @param {...Number} x Zero or more numbers, representing each component of the vector.
+   * @param {...Number} x List of numbers representing each component of the vector.
    * @return {p5.Vector} new <a href="#/p5.Vector">p5.Vector</a> object.
    *
    * @example
@@ -92,21 +92,8 @@ function math(p5, fn) {
    *   point(pos);
    * }
    */
-  fn.createVector = function (x, y, z) {
-    if (arguments.length === 0) {
-      p5._friendlyError(
-        'In 1.x, createVector() was a shortcut for createVector(0, 0, 0). In 2.x, p5.js has vectors of any dimension, so you must provide your desired number of zeros. Use createVector(0, 0) for a 2D vector and createVector(0, 0, 0) for a 3D vector.'
-      );
-    }
-    if (this instanceof p5) {
-      return new p5.Vector(
-        this._fromRadians.bind(this),
-        this._toRadians.bind(this),
-        ...arguments
-      );
-    } else {
-      return new p5.Vector(x, y, z);
-    }
+  fn.createVector = function (...args) {
+    return new p5.Vector(...args);
   };
 
   /**