Refactor: Move getNoiseShaderSnippet to strands backend#8705
Open
LalitNarayanYadav wants to merge 1 commit intoprocessing:dev-2.0from
Open
Refactor: Move getNoiseShaderSnippet to strands backend#8705LalitNarayanYadav wants to merge 1 commit intoprocessing:dev-2.0from
LalitNarayanYadav wants to merge 1 commit intoprocessing:dev-2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #8670
Changes
Refactored
getNoiseShaderSnippetto be part of the strands backend instead of individual renderers.Key updates
getNoiseShaderSnippetto:strands_glslBackendstrands_wgslBackendstrands_apito use:Changes
Removed duplicated implementations from:
Reason
Previously,
noise()shader support depended on renderer-specific implementations, leading to duplication and tighter coupling.Moving this logic into the backend:
Testing
noise()works in shaders without renderer-specific dependenciesPR Checklist
npm run lintpasses