Skip to content

Make sure we don't transpile uniform callbacks#8709

Merged
davepagurek merged 2 commits intodev-2.0from
fix/uniform-callbacks
Apr 7, 2026
Merged

Make sure we don't transpile uniform callbacks#8709
davepagurek merged 2 commits intodev-2.0from
fix/uniform-callbacks

Conversation

@davepagurek
Copy link
Copy Markdown
Contributor

Resolves #8707

Changes

  • More consistently applies early returns for nodes that are direct descendants of a uniform* function (the cause of the original bug)
  • Also collects the names of callback functions that are not direct descendants (i.e., ones passed in by name), which also shouldn't get parsed
  • Added test cases for all of the above

PR Checklist

@p5-bot
Copy link
Copy Markdown

p5-bot bot commented Apr 7, 2026

Continuous Release

CDN link

Published Packages

Commit hash: de29d3b

Previous deployments

This is an automated message.

@davepagurek davepagurek merged commit 1f0816d into dev-2.0 Apr 7, 2026
6 checks passed
@davepagurek davepagurek deleted the fix/uniform-callbacks branch April 7, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant