remove unused @requires from all jsdoc#8713
Open
nbogie wants to merge 2 commits intoprocessing:dev-2.0from
Open
remove unused @requires from all jsdoc#8713nbogie wants to merge 2 commits intoprocessing:dev-2.0from
@requires from all jsdoc#8713nbogie wants to merge 2 commits intoprocessing:dev-2.0from
Conversation
Contributor
Author
|
tested website generation too, now. (was blocked by #1321) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8628
Changes:
changes
testing
npm run docsruns ok.p5.js-website reference generation: runs and presents ok
generated type declarations and parameterData.json all look ok (contents are the same except ordering has changed).
npm run test:typespassesnote: comparing two versions of parameterData.json by first sorting all arrays can be done like this (assuming the
jqutility is installed):misc notes
remove with find + sed:
...then visually inspect changes with
git diffPR Checklist
npm run lintpasses