Minor WebGL->WebGPU fixes#8731
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few things that came up when testing a p5.strands tutorial sketch in WebGPU mode:
depth: falseare brokennoSmooth()throws an error and doesn't workcreateCanvasas needing to beawaited in WebGPU mode in the description or the typestextureSampledoesn't work in conditional branches with uniforms as conditionstextureSampleLevel, which is equivalent for us rn while we don't have mipmaps, and works in uniform conditionalsThis contains some small fixes for all of those oversights and adds little unit tests for each.