Add saveGif parameter validation#8830
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Collaborator
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
Is this related to any issue, can you please mention the issue which your PR resolves?
Author
|
Hi @perminder-17, this isn't tied to a specific issue. I noticed it while looking into the parameter validation for other image API functions, and added this to ensure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
saveGif()does not run the standard p5 argument validator, so invalid arguments bypass the library's normalValidationErrorpath.Root cause
The API implementation never called
p5._validateParameters('saveGif', arguments)even though the rest of the image API follows that pattern and the existing tests expect it.Why this fix is correct
Calling the shared validator at the start restores the expected argument-validation behavior without changing the rest of
saveGif(). I verified the three targetedsaveGifwrong-type tests in headless Chrome after this change.