Skip to content

Fix saveGif to silent no-op for non-positive duration #8842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chessing234 wants to merge 3 commits into from
+12 −0
Closed

Fix saveGif to silent no-op for non-positive duration #8842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fc7b42
Fix saveGif crash on invalid non-positive duration
Chessing234 May 26, 2026
36731d1
Fix saveGif duration validation to be a silent no-op
Chessing234 May 28, 2026
1345584
Fix saveGif to silent no-op for non-positive duration
Chessing234 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/image/loading_displaying.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,9 @@ p5.prototype.saveGif = async function(
if (typeof duration !== 'number') {
throw TypeError('Duration parameter must be a number');
}
if (duration <= 0) {
return;
}

// extract variables for more comfortable use
const delay = (options && options.delay) || 0; // in seconds
Expand Down
9 changes: 9 additions & 0 deletions test/unit/image/downloading.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,15 @@ suite('p5.prototype.saveGif', function() {
});
});

test('should silently return if duration is less than or equal to 0', function() {
assert.doesNotThrow(function() {
myp5.saveGif('myGif', 0);
});
assert.doesNotThrow(function() {
myp5.saveGif('myGif', -5);
});
});

testWithDownload('should download a GIF', async function(blobContainer) {
myp5.saveGif(myGif, 3, 2);
await waitForBlob(blobContainer);
Expand Down