Fix TRIANGLE_FAN immediate mode support#8974
Merged
Merged
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: b2b0723 Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8972
Changes
In the refactor that added WebGPU mode,
TRIANGLE_FANmode got lost -- WebGPU does not natively support it, so I initially took it out, but forgot to add it back in.This adds it back, natively in WebGL, and by converting to
TRIANGLESmode in WebGPU, and adds tests so it can't accidentally get lost again!Live: https://editor.p5js.org/davepagurek/sketches/4i9LjRxPh
PR Checklist
npm run lintpasses