Fix examples 002+006 and clean up variable declarations in all examples#90
Open
nbogie wants to merge 2 commits into
Open
Fix examples 002+006 and clean up variable declarations in all examples#90nbogie wants to merge 2 commits into
nbogie wants to merge 2 commits into
Conversation
002 was missing await for loadSound 006 intended (undeclared) variable name `noise` was colliding with p5's global fn of same name. Slight tidy of 006 to declare all variables.
…ed, (and more in details): * Declare all variables (locally, if possible). * Remove unused variables. * move towards consistent common variable names (e.g. "reverb" over "verb", "delay" over "del") * use "noiseGen" var name instead of "noise", to avoid possible collision/confusion with p5's noise()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noisewas colliding with p5's global fn of same name.Testing status:
These local examples now ALL reliably pass against chromium.