Skip to content

Commit 58dedb9

Browse files
committed
Update TODO
1 parent cfb36ce commit 58dedb9

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

TODO.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,18 @@
88
- [x] Support online events. For online events, do not show the minimap. Show a link to the event online platform (zoom webinar, or similar, provided by the event organizer) instead of the address. Add an "Online Event" label to the event details. Have a different icon for online events on the map (e.g. a wifi signal icon instead of the location pin).
99
- [x] Support linking to specific events on the map (e.g. via URL query parameter) and use this for the share button in the event details
1010
- [x] Fix share button to use the standard icon (arrow pointing up out of a box) and dropdown menu with options to copy link to clipboard and share on social media (twitter, facebook, linkedin, etc.). The copied link should include a URL query parameter to link to the specific event on the map, and the map should automatically open the popup for that event when the page is loaded with that query parameter.
11+
- [x] Fix popup color background in dark mode (currently too close to the sea color, making it hard to visually separate from the map)
12+
- [x] Move the light/dark mode toggle to an easily accessible place in the UI, such as the top right corner of the map, instead of being hidden in the side panel.
1113
- [ ] Have the action add a comment on the issue when the data is not valid, with friendly human readable error messages to help the user fix the issue. For example, if the date format is invalid, it should say "The date format is invalid (found: `Wed 15th`). Please use `YYYY-MM-DD` format." or something similar. Make a list of all the possible validation errors and the corresponding error messages to show to the user. The comment should format the feedback in a clear and easy to understand way, and also include instructions on how to fix the errors. If multiple errors are found, list them all in the same comment in a clear and organized way (e.g. using bullet points or a table).
1214
- [ ] Fix the Review checklist to account for the new TBD date/time/location and online event features.
1315
- [ ] Add a "Submitted by" field to the event details, showing the github account url of the user who submitted the event. This can be automatically added in the workflow when a new PR is created for the event, by getting the github username from the issue that triggered the workflow and adding it to the event data.
1416
- [ ] Add github issue template to submit a new event, to make it easier for maintainers to add new events to the map. The template should include all the necessary fields and instructions on how to fill them out, and also ask for the name and contact information of the maintainer who will be responsible for keeping the event data up to date. Link to this template in the "Submit your event" hero button. Add a workflow to automatically create a new branch and pull request when a new issue is created with the "New Event" template. It should also automatically add the "Needs Review" label to the issue and assign it to the PCD team. In the pull request description, include a checklist for the maintainers to review the event data and merge the PR if everything looks good. The workflow should add the new event to the nodes.json file and also create a new markdown file for the event details page with the provided information (we should migrate from long_description to getting the data from the markdown file). It should also automatically close the issue once the PR is merged (`closes #issue_number` in the PR description). Also handle malformed data (e.g. missing fields, invalid date format, etc.) by adding a validation step in the workflow and commenting on the issue with friendly human readable errors if the data is not valid.
1517
- [ ] Add link to discussion for events that have a forum thread
16-
- [ ] Fix popup color background in dark mode (currently too close to the sea color, making it hard to visually separate from the map)
1718
- [ ] Fractional zoom levels cause gaps in the map tiles on Chromium. (this is a known issue with Leaflet, see: https://github.com/Leaflet/Leaflet/issues/3575)
1819
- [ ] Add a "Submitted date" field to the event details, showing when the event was first submitted. This can be automatically added in the workflow when a new PR is created for the event.
19-
- [ ] Move the light/dark mode toggle to an easily accessible place in the UI, such as the top right corner of the map, instead of being hidden in the side panel.
2020
- [ ] Add an optional total event count to the map view, showing the total number of events currently on the map. This can be added as a large badge in the top left corner of the map, with a tooltip that says "Total number of PCD events worldwide: XXX". Only show this badge if there are more than 10 events on the map.
2121
- [ ] Generate og tags and og images for the event details pages, to make them look nice when shared on social media. The og image can be generated using a template with the event name, date and location overlaid on a background image of the map or something similar.
22+
- [ ] Label "new" on the map for events that were added in the last 7 days, to help users discover new events that were recently added to the map. This can be a small badge or icon next to the event name in the popup and in the side panel.
2223

2324
## Later improvements (not for MVP):
2425
- [ ] Add submission form with confirmation email when the event is approved and published.

0 commit comments

Comments
 (0)