Skip to content

Commit 5a53434

Browse files
SableRafclaude
andcommitted
Improve PR review checklist with specific, conditional items
Replace the generic checklist items with targeted checks: show the actual event name and contact info inline, and add conditional items for blank short/long descriptions so reviewers must explicitly confirm they're intentionally empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent b9410db commit 5a53434

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

.github/scripts/process-new-event-issue.mjs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ function buildValidationComment(errors) {
146146
].join('\n');
147147
}
148148

149-
function buildPrBody(number, name, submitterLogin, isOnlineEvent, eventDate, startTime, address, plusCodeNote, rawPlusCode) {
149+
function buildPrBody(number, name, submitterLogin, isOnlineEvent, eventDate, startTime, address, plusCodeNote, rawPlusCode, shortDescription, fullDescription, contactName, contactEmail) {
150150
const submitterMention = submitterLogin ? `@${submitterLogin}` : 'the submitter';
151151
const locationLine = isOnlineEvent
152152
? '- [ ] Online event URL is correct and accessible'
@@ -175,9 +175,10 @@ function buildPrBody(number, name, submitterLogin, isOnlineEvent, eventDate, sta
175175
`Submitted by ${submitterMention}.`,
176176
'',
177177
'Review checklist:',
178-
'- [ ] Event name and short description are ready to publish',
179-
'- [ ] Full event description is ready to publish (or intentionally blank)',
180-
'- [ ] Public contact info is correct',
178+
`- [ ] Event name "${name}" is correct`,
179+
`- [ ] Public contact info "${contactName} <${contactEmail}>" is correct`,
180+
...(shortDescription ? [] : ['- [ ] Short description is left blank — confirm this is intentional']),
181+
...(fullDescription ? [] : ['- [ ] Long description is left blank — confirm this is intentional']),
181182
dateLine,
182183
locationLine,
183184
'- [ ] Check the map and event details page in the **Netlify preview** (link posted below by the Netlify bot)',
@@ -386,7 +387,7 @@ async function main() {
386387
await fs.writeFile(metadataPath, `${JSON.stringify(nodeRecord, null, 2)}\n`);
387388

388389
const prBodyPath = path.join(RUNNER_TEMP, `new-event-${issueNumber}-pr-body.md`);
389-
await fs.writeFile(prBodyPath, buildPrBody(issueNumber, eventName, submitterLogin, isOnlineEvent, eventDate, startTime, address, plusCodeNote, rawPlusCode));
390+
await fs.writeFile(prBodyPath, buildPrBody(issueNumber, eventName, submitterLogin, isOnlineEvent, eventDate, startTime, address, plusCodeNote, rawPlusCode, shortDescription, fullDescription, primaryContactName, contactEmail));
390391

391392
console.log(`[process-new-event-issue] validation passed — event id: ${eventId}`);
392393
await setOutput('valid', 'true');

0 commit comments

Comments
 (0)