Skip to content

Commit f946a16

Browse files
committed
Make Maven signing conditional via property
Gate calls to signAllPublications() behind a project property so signing only occurs when explicitly enabled. The release workflow now exports ORG_GRADLE_PROJECT_signMavenPackages=true for relevant jobs, and build scripts were updated to check the property before signing (core, java libraries: dxf, io, net, pdf, serial, svg). The preprocessor signing check was also adjusted to look for the signing.signMavenPackages property. This lets CI enable signing when keys are available and avoids signing failures when signing credentials are not configured.
1 parent 78214c0 commit f946a16

File tree

9 files changed

+18
-8
lines changed

9 files changed

+18
-8
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ jobs:
6969
ORG_GRADLE_PROJECT_mavenCentralUsername: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
7070
ORG_GRADLE_PROJECT_mavenCentralPassword: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
7171

72+
ORG_GRADLE_PROJECT_signMavenPackages: true
7273
ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_IN_MEMORY_KEY }}
7374
ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_IN_MEMORY_KEY_PASSWORD }}
7475

@@ -92,6 +93,7 @@ jobs:
9293
GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }}
9394
GRADLE_PUBLISH_SECRET: ${{ secrets.GRADLE_PUBLISH_SECRET }}
9495

96+
ORG_GRADLE_PROJECT_signMavenPackages: true
9597
ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_IN_MEMORY_KEY }}
9698
ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_IN_MEMORY_KEY_PASSWORD }}
9799

@@ -104,6 +106,7 @@ jobs:
104106
GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }}
105107
GRADLE_PUBLISH_SECRET: ${{ secrets.GRADLE_PUBLISH_SECRET }}
106108

109+
ORG_GRADLE_PROJECT_signMavenPackages: true
107110
ORG_GRADLE_PROJECT_signingInMemoryKey: ${{ secrets.SIGNING_IN_MEMORY_KEY }}
108111
ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.SIGNING_IN_MEMORY_KEY_PASSWORD }}
109112

core/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ dependencies {
3838

3939
mavenPublishing{
4040
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
41-
signAllPublications()
41+
if (project.hasProperty("signMavenPackages"))
42+
signAllPublications()
4243

4344
pom{
4445
name.set("Processing Core")

java/libraries/dxf/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ sourceSets {
3232

3333
mavenPublishing {
3434
publishToMavenCentral(com.vanniktech.maven.publish.SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
35-
signAllPublications()
35+
if (project.hasProperty("signing.signMavenPackages"))
36+
signAllPublications()
3637
coordinates("$group.core", name, version.toString())
3738

3839
pom {

java/libraries/io/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ mavenPublishing {
6161
coordinates("$group.core", name, version.toString())
6262
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
6363

64-
signAllPublications()
64+
if (project.hasProperty("signMavenPackages"))
65+
signAllPublications()
6566

6667
pom {
6768
name.set("Processing IO")

java/libraries/net/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ mavenPublishing {
5353
coordinates("$group.core", name, version.toString())
5454
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
5555

56-
signAllPublications()
56+
if (project.hasProperty("signMavenPackages"))
57+
signAllPublications()
5758

5859
pom {
5960
name.set("Processing Net")

java/libraries/pdf/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ mavenPublishing{
5555
coordinates("$group.core", name, version.toString())
5656
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
5757

58-
signAllPublications()
58+
if (project.hasProperty("signMavenPackages"))
59+
signAllPublications()
5960

6061
pom{
6162
name.set("Processing PDF")

java/libraries/serial/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ mavenPublishing {
5555
coordinates("$group.core", name, version.toString())
5656
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
5757

58-
signAllPublications()
58+
if (project.hasProperty("signMavenPackages"))
59+
signAllPublications()
5960

6061
pom {
6162
name.set("Processing Serial")

java/libraries/svg/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ mavenPublishing {
5555
coordinates("$group.core", name, version.toString())
5656
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
5757

58-
signAllPublications()
58+
if (project.hasProperty("signMavenPackages"))
59+
signAllPublications()
5960

6061
pom {
6162
name.set("Processing SVG")

java/preprocessor/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ mavenPublishing{
5050
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
5151

5252
// Only sign if signing is set up
53-
if(project.hasProperty("signing.keyId") || project.hasProperty("signingInMemoryKey"))
53+
if (project.hasProperty("signing.signMavenPackages"))
5454
signAllPublications()
5555

5656
pom{

0 commit comments

Comments
 (0)