refactor(connection): remove stale client recovery fallback

The SOCKET_DIED fallback in the stale disconnect handler is unreachable:
in every code path that reassigns this.xmpp, the state machine has
already transitioned out of `connected` (via a synchronous SOCKET_DIED)
before any stale disconnect can fire. The connect() guard from the
previous commit eliminates the only remaining scenario.

Author: mremond

packages/fluux-sdk/src/core/modules/Connection.test.ts

@@ -2783,21 +2783,23 @@ describe('XMPPClient Connection', () => {
       expect(mockClientFactory).toHaveBeenCalled()
     })
 
-    it('should force reconnect recovery when stale disconnect arrives while still connected', async () => {
+    it('should ignore stale disconnect without triggering reconnect', async () => {
       // Simulate the race: internal xmpp ref was already replaced/nulled,
       // but the old socket disconnect event arrives while machine is connected.
       ;(xmppClient.connection as any).xmpp = null
 
+      vi.mocked(mockStores.connection.setStatus).mockClear()
+
       mockXmppClientInstance._emit('disconnect', {
         clean: false,
         reason: { code: 1006, reason: 'ECONNERROR' },
       })
 
-      expect(mockStores.console.addEvent).toHaveBeenCalledWith(
-        'Socket closed from stale client while connected, forcing reconnect recovery',
-        'connection'
-      )
-      expect(mockStores.connection.setStatus).toHaveBeenCalledWith('reconnecting')
+      // Stale disconnect should be logged and ignored — no reconnect triggered.
+      // In every real code path, the machine has already transitioned out of
+      // `connected` before any stale disconnect arrives (SOCKET_DIED is sent
+      // synchronously before forceDestroyClient strips listeners).
+      expect(mockStores.connection.setStatus).not.toHaveBeenCalledWith('reconnecting')
     })
 
     it('should schedule reconnect after SM verify timeout without disconnect event', async () => {

packages/fluux-sdk/src/core/modules/Connection.ts

@@ -1676,20 +1676,6 @@ export class Connection extends BaseModule {
           )
         }
 
-        // Recovery fallback: if the machine still believes we're connected
-        // when a stale disconnect arrives, force reconnect transition instead
-        // of silently staying in a wedged connected state.
-        // Skip if already in a terminal state (e.g. conflict, authFailed) — the
-        // stale socket close from the conflicted session must not trigger a
-        // reconnect that would create another resource conflict loop.
-        if (typeof machineState === 'object' && 'connected' in machineState && !this.isInTerminalState()) {
-          logWarn(`Stale disconnect arrived while machine still connected (state=${JSON.stringify(machineState)}${closeInfo})`)
-          this.stores.console.addEvent(
-            'Socket closed from stale client while connected, forcing reconnect recovery',
-            'connection'
-          )
-          this.sendMachineEvent({ type: 'SOCKET_DIED' }, 'disconnect:stale-connected')
-        }
         return
       }