Fix migration failure for missing procrastinate_jobs_queue_name_idx#1476
Open
medihack wants to merge 2 commits intoprocrastinate-org:mainfrom
Open
Fix migration failure for missing procrastinate_jobs_queue_name_idx#1476medihack wants to merge 2 commits intoprocrastinate-org:mainfrom
medihack wants to merge 2 commits intoprocrastinate-org:mainfrom
Conversation
The index procrastinate_jobs_queue_name_idx was added to schema.sql in v0.11.0 but never had a corresponding migration. The migration 03.00.00_50_post_cancel_notification.sql tried to rename this index, which failed for users who only used migrations to set up their database. This fix adds the missing historical migration file at the correct version (00.11.00_04_add_jobs_queue_name_idx.sql) to create the index. This allows the later migration to simply rename it as originally intended. Fixes procrastinate-org#1461
for more information, see https://pre-commit.ci
Member
Author
|
I am not sure if it is as easy as this, or whether we should ignore the failing test (which is done for new migrations, not for retrospectively added ones). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1461
The index procrastinate_jobs_queue_name_idx was added to schema.sql in v0.11.0 but lacked a corresponding migration. The migration 03.00.00_50_post_cancel_notification.sql tried to rename this index, which failed for users who only used migrations to set up their database.
This fix adds the missing historical migration file at the correct version (00.11.00_04_add_jobs_queue_name_idx.sql) to create the index. This allows the later migration to simply rename it as originally intended.
Successful PR Checklist:
PR label(s):