added update group handler#19
Merged
Merged
Conversation
petrCher
requested changes
May 3, 2026
|
|
||
| @classmethod | ||
| async def update_group(cls, db: Session, id: int, group_info: GroupPost): | ||
| group = Group.get(session=db.session, id=id) |
Member
There was a problem hiding this comment.
здесь можно просто сделать гет запрос, без присвоения результата в переменную
| @classmethod | ||
| async def update_group(cls, db: Session, id: int, group_info: GroupPost): | ||
| group = Group.get(session=db.session, id=id) | ||
| updated_group = Group.update(group.id, session=db.session, **group_info.model_dump()) |
Member
There was a problem hiding this comment.
а здесь соответственно айдишник передавать не group.id а просто id из аргументов самой функции, ты же уже все равно проверил что этот айди валиден
petrCher
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Написана ручка update group
Closes #14
Детали реализации
В файле modal_backend\utils\services.py написана логика
В файле modal_backend\routes\groups.py написана сама ручка
Новых схем не писал, только метод класса в services.py
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?