added route#23
Merged
Merged
Conversation
petrCher
reviewed
May 8, 2026
| return ServiceGet.model_validate(new_service) | ||
|
|
||
|
|
||
| @service.patch("/{id}", response_model=ServiceGet) |
Member
There was a problem hiding this comment.
лучше здесь использовать patch а не put, так как в логике метода update models/base.py присутствует проверка обновления только нужных переданных данных, если будем потом модернизировать данный эндпоинт, то в случае необязательности определенных полей, они могут быть заменены на дефолтное значение(если не будут переданы теле запроса)
petrCher
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Написал метод и соответствующий маршрут PUT service/{id}