Conversation
|
💩 Code linting failed, use |
Summary
|
petrCher
requested changes
Apr 30, 2026
| Retrieves a list of items. If `type_id` is specified, only items of that type are returned. | ||
|
|
||
| - **type_id**: The ID of the item type (optional). | ||
| - **order_by**: Sort field (default: id). |
Member
There was a problem hiding this comment.
надо написать что происходит в логике, просто сейчас непонятно как параметры связаны между собой, то есть для сортировки по возрастанию например должен быть указан параметр по чему сортировать
| column = getattr(Item, order_by, Item.id) | ||
| if order == "desc": | ||
| query = query.order_by(column.desc()) | ||
| else: |
Member
There was a problem hiding this comment.
у тебя три варианта, asс desc и None
так что такой елз делать не надо
| if is_available is not None: | ||
| query = query.filter(Item.is_available == is_available) | ||
|
|
||
| if order_by is not None and order is not None: |
Member
There was a problem hiding this comment.
а зачем проверка на order not null?
Member
There was a problem hiding this comment.
я бы вообще убрал всю эту проверку для order_by и order
ты же все равно делаешь getattr и в случае несуществования order_by будет задаваться сортировка по айди, что верно
|
💩 Code linting failed, use |
petrCher
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Изменения
Добавлена сортировка предметов по полю
Добавлено направление сортировки по asc/desc
Добавлен флаг is_available
Детали реализации
В get_items добавлено order_by: str = "id", order: str = "asc", is_available: bool = Query(None)
сортировка через getattr(Item, order_by, Item.id) с проверкой на asc/desc