Skip to content

Commit 9de68dc

Browse files
authored
Fix is_hidden patch error (#63)
1 parent 67d0b3c commit 9de68dc

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

services_backend/routes/button.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ def update_button(
244244
raise HTTPException(status_code=404, detail="Category does not exist")
245245
if not button:
246246
raise HTTPException(status_code=404, detail="Button does not exist")
247-
if not any(button_inp.model_dump().values()):
247+
if all(value is None for value in button_inp.model_dump().values()):
248248
raise HTTPException(status_code=400, detail="Empty schema")
249249
if button.category_id != category_id:
250250
raise HTTPException(status_code=404, detail="Button is not this category")

tests/api/button.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,21 @@ def test_patch_to_hide_success(client, db_button, db_category):
291291
assert res.json()["view"] == "hidden"
292292

293293

294+
def test_patch_to_unhide_success(client, db_button, db_category):
295+
body = {"is_hidden": True}
296+
res = client.patch(f"/category/{db_category.id}/button/{db_button.id}", data=json.dumps(body))
297+
assert res.status_code == status.HTTP_200_OK
298+
res_body = res.json()
299+
assert res_body["is_hidden"] == True
300+
body["is_hidden"] = False
301+
res = client.patch(f"/category/{db_category.id}/button/{db_button.id}", data=json.dumps(body))
302+
assert res.status_code == status.HTTP_200_OK
303+
res_body = res.json()
304+
assert res_body["name"] == db_button.name
305+
assert res_body["is_hidden"] == False
306+
assert res_body["link"] == db_button.link
307+
308+
294309
def test_delete_hidden_success(client, dbsession, db_button, db_category):
295310
db_button.is_hidden = True
296311
dbsession.commit()

0 commit comments

Comments
 (0)