Сокращена и улучшена логика ручки patch-event-id

Author: CaseAsLimbo

calendar_backend/routes/event/event.py

@@ -1,16 +1,17 @@
 import logging
 from datetime import date, timedelta
 from typing import Literal
+from itertools import zip_longest
 
 from auth_lib.fastapi import UnionAuth
 from fastapi import APIRouter, Depends, Query, status
 from fastapi.responses import FileResponse, JSONResponse
 from fastapi_sqlalchemy import db
 from pydantic import TypeAdapter
 
-from calendar_backend.exceptions import NotEnoughCriteria
+from calendar_backend.exceptions import NotEnoughCriteria, ObjectNotFound
 from calendar_backend.methods import list_calendar
-from calendar_backend.models import Event, Group, Lecturer, Room
+from calendar_backend.models import Event, Group, Lecturer, Room, EventsRooms, EventsGroups, EventsLecturers
 from calendar_backend.routes.models import EventGet
 from calendar_backend.routes.models.event import (
     EventPatch,
@@ -199,7 +200,49 @@ async def patch_event_by_name(
 async def patch_event(
     id: int, event_inp: EventPatch, _=Depends(UnionAuth(scopes=["timetable.event.update"]))
 ) -> EventGet:
-    patched = Event.update(id, session=db.session, **event_inp.model_dump(exclude_unset=True))
+
+    # проверяем, что событие с таким id существует
+    Events = db.session.query(Event).filter(Event.id == id).one_or_none()
+    if not Events:
+        raise ObjectNotFound(type=type(Events), ids=id)
+
+    event_upd_data = event_inp.model_dump(exclude_unset=True)
+    # получаем списки id всех существующих аудиторий, групп и лекторов
+    all_rooms = [room.id for room in db.session.query(Room).all()]
+    all_groups = [group.id for group in db.session.query(Group).all()]
+    all_lecturers = [lecturer.id for lecturer in db.session.query(Lecturer).all()]
+    # проверяем cуществование заданных в body (room_, group_, lecturer_)*id 
+    for r, g, l in zip_longest(event_upd_data.get("room_id"), event_upd_data.get("group_id"), event_upd_data.get("lecturer_id"), fillvalue=None):
+        if r not in all_rooms:
+            raise ObjectNotFound(type=type(Room), ids=r)   
+        if g not in all_groups:
+            raise ObjectNotFound(type=type(Group), ids=g)   
+        if l not in all_lecturers:
+            raise ObjectNotFound(type=type(Lecturer), ids=l)   
+
+    def add_new_remove_old_ids(dbsession, event_id, artefact: str, event_instance, negotiator_instance) -> None:
+        """Вспомогательная фукнция описывающая удаление старых и добавление новых (room_, group_, lecturer_)*id - артефактов"""
+        # получаем множество артефактов события
+        event_artefacts = {room.id for room in getattr(event_instance, f"{artefact}")}
+        # получаем множетсво страрых артефактов
+        old_artefacts = event_artefacts - set(event_upd_data.get(f"{artefact}_id"))
+        # получаем множество новых артефактов
+        new_artefacts =  set(event_upd_data.get(f"{artefact}_id")) - event_artefacts
+        # получаем артефакты к удалению(уникальные старые)
+        to_remove = old_artefacts - new_artefacts
+        # получаем артефакты к созданию(уникальные новые)
+        to_add = new_artefacts - old_artefacts
+
+        if to_remove:
+            dbsession.query(negotiator_instance).filter(negotiator_instance.event_id==event_id, getattr(negotiator_instance, f"{artefact}_id").in_(to_remove)).delete()
+        if to_add:
+            dbsession.bulk_insert_mappings(negotiator_instance, [{"event_id" : f"{event_id}", f"{artefact}_id" : id_to_add} for id_to_add in to_add])
+
+    add_new_remove_old_ids(db.session, id, "room", Events, EventsRooms)
+    add_new_remove_old_ids(db.session, id, "group", Events, EventsGroups)
+    add_new_remove_old_ids(db.session, id, "lecturer", Events, EventsLecturers)
+
+    patched = Event.update(id, session=db.session, **event_upd_data)
     db.session.commit()
     return EventGet.model_validate(patched)