fix: return marketplace git install metadata (#3)

Co-authored-by: Simone <a1234@1234deMac-mini.local>

Author: op-simoneromeo

apps/web/src/app/api/modules/[slug]/install/__tests__/route.test.ts

@@ -6,7 +6,17 @@ import { TEST_MODULE } from "@/__tests__/helpers/supabase-mock";
 const mockUpdate = vi.fn();
 const mockInsert = vi.fn();
 let moduleLookupResult: { data: unknown; error: unknown } = {
-  data: { id: "mod-001", downloads: 42, version: "1.0.0" },
+  data: {
+    id: "mod-001",
+    name: "Test Scanner",
+    slug: "test-scanner",
+    downloads: 42,
+    version: "1.0.0",
+    git_url: "https://github.com/test/scanner",
+    license: "MIT",
+    min_threatcrush_version: ">=0.2.0",
+    os_support: ["linux"],
+  },
   error: null,
 };
 
@@ -55,7 +65,17 @@ describe("POST /api/modules/:slug/install", () => {
   beforeEach(() => {
     vi.clearAllMocks();
     moduleLookupResult = {
-      data: { id: "mod-001", downloads: 42, version: "1.0.0" },
+      data: {
+        id: "mod-001",
+        name: "Test Scanner",
+        slug: "test-scanner",
+        downloads: 42,
+        version: "1.0.0",
+        git_url: "https://github.com/test/scanner",
+        license: "MIT",
+        min_threatcrush_version: ">=0.2.0",
+        os_support: ["linux"],
+      },
       error: null,
     };
   });
@@ -70,6 +90,17 @@ describe("POST /api/modules/:slug/install", () => {
     expect(body.downloads).toBe(43);
   });
 
+  it("returns git install info from the marketplace module record", async () => {
+    const req = makeRequest({ platform: "linux" });
+    const res = await POST(req, makeContext("test-scanner"));
+    const body = await res.json();
+
+    expect(res.status).toBe(200);
+    expect(body.module.install.git_url).toBe("https://github.com/test/scanner");
+    expect(body.module.install.npm_package).toBeNull();
+    expect(body.module.install.tarball_url).toBeNull();
+  });
+
   it("logs install with platform info", async () => {
     const req = makeRequest({
       user_email: "user@example.com",

apps/web/src/app/api/modules/[slug]/install/route.ts

@@ -3,6 +3,35 @@ import { getSupabaseAdmin } from "@/lib/supabase";
 
 type RouteContext = { params: Promise<{ slug: string }> };
 
+const MODULE_INSTALL_COLUMNS =
+  "id, name, slug, version, downloads, git_url, min_threatcrush_version, os_support, license";
+
+function installPayload(mod: {
+  name: string;
+  slug: string;
+  version: string;
+  downloads?: number | null;
+  git_url?: string | null;
+  min_threatcrush_version?: string | null;
+  os_support?: string[] | null;
+  license?: string | null;
+}) {
+  return {
+    name: mod.name,
+    slug: mod.slug,
+    version: mod.version,
+    downloads: mod.downloads || 0,
+    license: mod.license,
+    min_threatcrush_version: mod.min_threatcrush_version,
+    os_support: mod.os_support,
+    install: {
+      npm_package: null,
+      git_url: mod.git_url || null,
+      tarball_url: null,
+    },
+  };
+}
+
 /**
  * GET /api/modules/[slug]/install
  * Query module install info without incrementing download count.
@@ -16,7 +45,7 @@ export async function GET(
 
   const { data: mod, error: modError } = await sb
     .from("modules")
-    .select("id, name, slug, version, downloads, git_url, npm_package, tarball_url, min_threatcrush_version, os_support, license")
+    .select(MODULE_INSTALL_COLUMNS)
     .eq("slug", slug)
     .eq("published", true)
     .single();
@@ -26,20 +55,7 @@ export async function GET(
   }
 
   return NextResponse.json({
-    module: {
-      name: mod.name,
-      slug: mod.slug,
-      version: mod.version,
-      downloads: mod.downloads || 0,
-      license: mod.license,
-      min_threatcrush_version: mod.min_threatcrush_version,
-      os_support: mod.os_support,
-      install: {
-        npm_package: mod.npm_package || null,
-        git_url: mod.git_url || null,
-        tarball_url: mod.tarball_url || null,
-      },
-    },
+    module: installPayload(mod),
   });
 }
 
@@ -63,7 +79,7 @@ export async function POST(
   // Get module with full install info
   const { data: mod, error: modError } = await sb
     .from("modules")
-    .select("id, name, slug, version, downloads, git_url, npm_package, tarball_url, min_threatcrush_version, os_support, license")
+    .select(MODULE_INSTALL_COLUMNS)
     .eq("slug", slug)
     .eq("published", true)
     .single();
@@ -90,18 +106,6 @@ export async function POST(
   return NextResponse.json({
     success: true,
     downloads: newCount,
-    module: {
-      name: mod.name,
-      slug: mod.slug,
-      version: mod.version,
-      license: mod.license,
-      min_threatcrush_version: mod.min_threatcrush_version,
-      os_support: mod.os_support,
-      install: {
-        npm_package: mod.npm_package || null,
-        git_url: mod.git_url || null,
-        tarball_url: mod.tarball_url || null,
-      },
-    },
+    module: installPayload({ ...mod, downloads: newCount }),
   });
 }