fix: support IPv6 source addresses in auth log parser#32
Closed
pxivory-max wants to merge 1 commit into
Closed
Conversation
IP_REGEX only matched IPv4 dotted-quad addresses. Widen the character class to [0-9a-fA-F.:] and anchor on the trailing "port" keyword so both IPv4 and IPv6 addresses are captured. Fixes profullstack#28 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IP_REGEXcharacter class from IPv4-only (\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}) to[0-9a-fA-F.:]which covers both IPv4 and IPv6portkeyword to avoid over-matchingFixes #28
Gig: https://ugig.net/gigs/14eb1fad-1c95-4ba9-bd6f-5b6f9de1a664
Test plan
Failed password for root from 2001:db8::42 port 54321 ssh2→fields.ipshould be"2001:db8::42"Failed password for root from 203.0.113.10 port 54321 ssh2→fields.ipshould still be"203.0.113.10"