refactor(writer): harden interface generation

Author: andrepimpao

src/Writer/InterfaceWriter.php

@@ -6,9 +6,14 @@ class InterfaceWriter
 {
     private \SplFileObject $file;
 
-    public function __construct(private readonly string $interfaceName)
+    public function __construct(
+        private readonly string $interfaceName,
+        ?string $outputDirectory = null,
+    )
     {
-        $filename = sprintf('src/%s.php', $this->interfaceName);
+        $outputDirectory ??= dirname(__DIR__);
+        $filename = sprintf('%s/%s.php', rtrim($outputDirectory, '/'), $this->interfaceName);
+
         $this->file = new \SplFileObject($filename, 'w');
     }
 
@@ -100,10 +105,6 @@ private function formatType(string $type): string
 
     private function formatValue(mixed $value): string
     {
-        if (is_string($value)) {
-            return sprintf("'%s'", $value);
-        }
-
         if ($value === []) {
             return '[]';
         }
@@ -112,14 +113,6 @@ private function formatValue(mixed $value): string
             return 'null';
         }
 
-        if ($value === false) {
-            return 'false';
-        }
-
-        if ($value === true) {
-            return 'true';
-        }
-
-        return (string) $value;
+        return var_export($value, true);
     }
-}
+}

tests/Writer/InterfaceWriterTest.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace ProgrammatorDev\FluentValidator\Test\Writer;
+
+use PHPUnit\Framework\TestCase;
+use ProgrammatorDev\FluentValidator\Writer\InterfaceWriter;
+
+class InterfaceWriterTest extends TestCase
+{
+    public function testWritesToConfiguredOutputDirectoryAndEscapesDefaultValues(): void
+    {
+        $outputDirectory = sys_get_temp_dir() . '/fluent-validator-' . bin2hex(random_bytes(8));
+        mkdir($outputDirectory);
+
+        $filePath = $outputDirectory . '/ExampleInterface.php';
+
+        try {
+            $parameters = (new \ReflectionFunction(
+                fn (string $message = "It's valid", array $groups = [], mixed $payload = null) => null
+            ))->getParameters();
+
+            $writer = new InterfaceWriter('ExampleInterface', $outputDirectory);
+            $writer->writeInterfaceStart();
+            $writer->writeMethod('example', 'Validator', $parameters);
+            $writer->writeInterfaceEnd();
+
+            $contents = file_get_contents($filePath);
+
+            $this->assertStringContainsString("string \$message = 'It\\'s valid',", $contents);
+            $this->assertStringContainsString('array $groups = [],', $contents);
+            $this->assertStringContainsString('mixed $payload = null,', $contents);
+        }
+        finally {
+            if (is_file($filePath)) {
+                unlink($filePath);
+            }
+
+            rmdir($outputDirectory);
+        }
+    }
+}