fix(release): stop assets from silently overwriting each other

check-version:
- guard HEAD^ with git rev-parse so first commits don't crash the step

build:
- set fail-fast: false so one OS/target failing doesn't cancel the others
- simplify condition to version_changed (force already flows into it)
- give Swatinem/rust-cache a per-target key so the two macos-latest legs
  (x86_64 / aarch64) stop sharing (and corrupting) one cache
- run apt-get update before installing musl-tools

release:
- gate explicitly on version_changed
- abort if VERSION is empty or artifact count != 4, instead of silently
  shipping a partial release
- fix asset uploads: gh release upload --clobber matches by underlying
  filename, not --label, so binaries that are all literally named "pik"
  (linux-x86_64, macos-x86_64, macos-aarch64) clobbered each other one
  after another, leaving only the last "pik" and the uniquely-named
  pik.exe. Now each file is copied to a uniquely-named temp path before
  upload so every asset survives.
- track per-file upload failures and exit 1 if any fail, instead of
  succeeding silently

Author: programmersd21

.github/workflows/release.yml

@@ -68,11 +68,9 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
-
       - uses: dtolnay/rust-toolchain@stable
         with:
           targets: ${{ matrix.target }}
-
       - uses: Swatinem/rust-cache@v2
         with:
           key: ${{ matrix.target }}
@@ -139,13 +137,26 @@ jobs:
             exit 1
           fi
 
+          # Rename each file to its unique asset name before uploading.
+          # gh release upload --clobber matches on the underlying filename,
+          # not on --label, so multiple binaries all literally named "pik"
+          # would otherwise overwrite each other one-by-one.
+          mkdir -p /tmp/release-assets
+          RENAMED=()
+          for f in "${ASSETS[@]}"; do
+            dir=$(basename "$(dirname "$f")")
+            dest="/tmp/release-assets/${dir}"
+            cp "$f" "$dest"
+            RENAMED+=("$dest")
+          done
+
           gh release create "v$VERSION" --title "v$VERSION" --generate-notes
 
           FAILED=0
-          for f in "${ASSETS[@]}"; do
-            dir=$(basename "$(dirname "$f")")
-            echo "Uploading $f as $dir..."
-            if ! gh release upload "v$VERSION" "$f#$dir" --clobber; then
+          for f in "${RENAMED[@]}"; do
+            name=$(basename "$f")
+            echo "Uploading $f as $name..."
+            if ! gh release upload "v$VERSION" "$f" --clobber; then
               echo "Failed to upload $f"
               FAILED=1
             fi