Skip to content

additional metadata tests#366

Open
slingamn wants to merge 8 commits into
progval:masterfrom
slingamn:metadata_perms.1
Open

additional metadata tests#366
slingamn wants to merge 8 commits into
progval:masterfrom
slingamn:metadata_perms.1

Conversation

@slingamn
Copy link
Copy Markdown
Collaborator

No description provided.

@slingamn
Copy link
Copy Markdown
Collaborator Author

This appears to be a bug in the Unreal implementation, which responds to METADATA #chan LIST from a non-member with nothing (it should send FAIL METADATA KEY_NO_PERMISSION). Is the Unreal implementation currently maintained?

@progval
Copy link
Copy Markdown
Owner

progval commented Apr 19, 2026

not really, but you can send a PR to https://github.com/progval/unrealircd-contrib/blob/metadata2/files/metadata2.c

@slingamn
Copy link
Copy Markdown
Collaborator Author

I see two issues:

  1. METADATA LIST on a channel from a non-member gets no response, whereas it should get FAIL METADATA KEY_NO_PERMISISION #channel * :No permission (this issue probably applies to SYNC as well
  2. The response to METADATA CLEAR is not batched

@progval
Copy link
Copy Markdown
Owner

progval commented Apr 25, 2026

METADATA LIST on a channel from a non-member gets no response, whereas it should get FAIL METADATA KEY_NO_PERMISISION #channel * :No permission

Fixed, but not the way you expect, so the test still fails: progval/unrealircd-contrib@dac860c

this issue probably applies to SYNC as well

Indeed. Fixed: progval/unrealircd-contrib@306d391

The response to METADATA CLEAR is not batched

Fixed: progval/unrealircd-contrib@10b0141

@progval
Copy link
Copy Markdown
Owner

progval commented May 31, 2026

progval/unrealircd-contrib@eb6b619 solves the new Unreal failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants