Fix test mocking: patch IPython.get_ipython instead of module attribute

Author: pawelpaszki

src/codeflare_sdk/common/widgets/test_widgets.py

@@ -83,8 +83,8 @@ def test_cluster_apply_down_buttons(mocker):
 
 @patch.dict("os.environ", {}, clear=True)  # Mock environment with no variables
 def test_is_notebook_false():
-    # Also mock get_ipython to return None
-    with patch("codeflare_sdk.common.widgets.widgets.get_ipython", return_value=None):
+    # Mock get_ipython to return None (no IPython shell)
+    with patch("IPython.get_ipython", return_value=None):
         assert cf_widgets.is_notebook() is False
 
 
@@ -101,9 +101,7 @@ def test_is_notebook_with_zmq_shell():
     mock_shell = MagicMock()
     mock_shell.__class__.__name__ = "ZMQInteractiveShell"
 
-    with patch(
-        "codeflare_sdk.common.widgets.widgets.get_ipython", return_value=mock_shell
-    ):
+    with patch("IPython.get_ipython", return_value=mock_shell):
         assert cf_widgets.is_notebook() is True
 
 
@@ -113,9 +111,7 @@ def test_is_notebook_with_terminal_shell():
     mock_shell = MagicMock()
     mock_shell.__class__.__name__ = "TerminalInteractiveShell"
 
-    with patch(
-        "codeflare_sdk.common.widgets.widgets.get_ipython", return_value=mock_shell
-    ):
+    with patch("IPython.get_ipython", return_value=mock_shell):
         assert cf_widgets.is_notebook() is False
 
 
@@ -125,17 +121,14 @@ def test_is_notebook_with_terminal_shell():
 def test_is_notebook_with_jpy_parent_pid():
     """Test is_notebook returns True when JPY_PARENT_PID env var is set."""
     # Mock get_ipython to return None to test env var fallback
-    with patch("codeflare_sdk.common.widgets.widgets.get_ipython", return_value=None):
+    with patch("IPython.get_ipython", return_value=None):
         assert cf_widgets.is_notebook() is True
 
 
 @patch.dict("os.environ", {}, clear=True)  # No env vars
 def test_is_notebook_ipython_import_error():
     """Test is_notebook handles ImportError gracefully."""
-    with patch(
-        "codeflare_sdk.common.widgets.widgets.get_ipython",
-        side_effect=ImportError("No module named 'IPython'"),
-    ):
+    with patch.dict("sys.modules", {"IPython": None}):
         assert cf_widgets.is_notebook() is False