Skip to content

Commit d87aac4

Browse files
szaheropenshift-merge-bot[bot]
authored andcommitted
fix get_cluster() swaps CPU/memory requests and limits for head and workers
Signed-off-by: Saad Zaher <szaher@redhat.com>
1 parent cc1fefc commit d87aac4

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/codeflare_sdk/ray/cluster/cluster.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -831,16 +831,16 @@ def get_cluster(
831831
write_to_file=write_to_file,
832832
head_cpu_limits=resource["spec"]["headGroupSpec"]["template"]["spec"][
833833
"containers"
834-
][0]["resources"]["requests"]["cpu"],
834+
][0]["resources"]["limits"]["cpu"],
835835
head_cpu_requests=resource["spec"]["headGroupSpec"]["template"]["spec"][
836836
"containers"
837-
][0]["resources"]["limits"]["cpu"],
837+
][0]["resources"]["requests"]["cpu"],
838838
head_memory_limits=resource["spec"]["headGroupSpec"]["template"]["spec"][
839839
"containers"
840-
][0]["resources"]["requests"]["memory"],
840+
][0]["resources"]["limits"]["memory"],
841841
head_memory_requests=resource["spec"]["headGroupSpec"]["template"]["spec"][
842842
"containers"
843-
][0]["resources"]["limits"]["memory"],
843+
][0]["resources"]["requests"]["memory"],
844844
num_workers=resource["spec"]["workerGroupSpecs"][0]["minReplicas"],
845845
worker_cpu_limits=resource["spec"]["workerGroupSpecs"][0]["template"]["spec"][
846846
"containers"
@@ -850,10 +850,10 @@ def get_cluster(
850850
][0]["resources"]["requests"]["cpu"],
851851
worker_memory_limits=resource["spec"]["workerGroupSpecs"][0]["template"][
852852
"spec"
853-
]["containers"][0]["resources"]["requests"]["memory"],
853+
]["containers"][0]["resources"]["limits"]["memory"],
854854
worker_memory_requests=resource["spec"]["workerGroupSpecs"][0]["template"][
855855
"spec"
856-
]["containers"][0]["resources"]["limits"]["memory"],
856+
]["containers"][0]["resources"]["requests"]["memory"],
857857
head_extended_resource_requests=head_extended_resources,
858858
worker_extended_resource_requests=worker_extended_resources,
859859
)

0 commit comments

Comments
 (0)