Skip to content

fix typo in _client_verify_tls#1030

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
fix-tls-issue
Mar 23, 2026
Merged

fix typo in _client_verify_tls#1030
openshift-merge-bot[bot] merged 1 commit into
mainfrom
fix-tls-issue

Conversation

@szaher

@szaher szaher commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Issue link

What changes have been made

add a missing parentheses in _client_verify_tls for the func that checks for OpenShift cluster or not.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Signed-off-by: Saad Zaher <szaher@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026
@szaher szaher marked this pull request as ready for review March 23, 2026 10:47
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026
@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.15%. Comparing base (083212d) to head (b59a819).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          23       23           
  Lines        2238     2238           
=======================================
  Hits         2152     2152           
  Misses         86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026
@openshift-ci

openshift-ci Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit cc1fefc into main Mar 23, 2026
26 checks passed
@szaher szaher deleted the fix-tls-issue branch March 23, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants