Skip to content

fix(k8s_utils): close namespace file handle with context manager #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Mar 30, 2026
Merged

fix(k8s_utils): close namespace file handle with context manager #1033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/codeflare_sdk/common/utils/k8s_utils.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ def get_current_namespace(): # pragma: no cover
"""
if os.path.isfile("/var/run/secrets/kubernetes.io/serviceaccount/namespace"):
try:
file = open("/var/run/secrets/kubernetes.io/serviceaccount/namespace", "r")
active_context = file.readline().strip("\n")
return active_context
# Fix for RHOAIENG-54703: use context manager to ensure file is closed
with open(
"/var/run/secrets/kubernetes.io/serviceaccount/namespace", "r"
) as file:
return file.readline().strip("\n")
except Exception as e:
print("Unable to find current namespace")
print("Trying to gather namespace from current context")
Expand Down
Loading