Skip to content

RHOAIENG-57401: fix fragile if/elif chain in Cluster.status() #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Mar 30, 2026
Merged

RHOAIENG-57401: fix fragile if/elif chain in Cluster.status() #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/codeflare_sdk/ray/cluster/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,21 +351,21 @@ def status(
# check the ray cluster status
cluster = _ray_cluster_status(self.config.name, self.config.namespace)
if cluster:
if cluster.status == RayClusterStatus.SUSPENDED:
ready = False
status = CodeFlareClusterStatus.SUSPENDED
if cluster.status == RayClusterStatus.UNKNOWN:
ready = False
status = CodeFlareClusterStatus.STARTING
if cluster.status == RayClusterStatus.READY:
ready = True
status = CodeFlareClusterStatus.READY
elif cluster.status == RayClusterStatus.SUSPENDED:
ready = False
status = CodeFlareClusterStatus.SUSPENDED
elif cluster.status in [
RayClusterStatus.UNHEALTHY,
RayClusterStatus.FAILED,
]:
ready = False
status = CodeFlareClusterStatus.FAILED
elif cluster.status == RayClusterStatus.UNKNOWN:
ready = False
status = CodeFlareClusterStatus.STARTING

if print_to_console:
# overriding the number of gpus with requested
Expand Down
5 changes: 5 additions & 0 deletions src/codeflare_sdk/ray/cluster/test_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ def test_cluster_status(mocker):
assert status == CodeFlareClusterStatus.READY
assert ready is True

fake_ray.status = RayClusterStatus.SUSPENDED
status, ready = cf.status()
assert status == CodeFlareClusterStatus.SUSPENDED
assert ready is False


def rc_status_fields(group, version, namespace, plural, *args):
assert group == "ray.io"
Expand Down
Loading