Skip to content

RHOAIENG-29722: use cluster.apply() in demo text#1056

Merged
DavidAdaRH merged 1 commit into
project-codeflare:mainfrom
DavidAdaRH:RHOAIENG-29722
Apr 9, 2026
Merged

RHOAIENG-29722: use cluster.apply() in demo text#1056
DavidAdaRH merged 1 commit into
project-codeflare:mainfrom
DavidAdaRH:RHOAIENG-29722

Conversation

@DavidAdaRH

Copy link
Copy Markdown
Contributor

Issue link

https://redhat.atlassian.net/browse/RHOAIENG-29722

What changes have been made

  • Notebook markdown in three demos now says cluster.apply() instead of up() (code was already apply()).

Verification steps

  • Verify those cells: text and code both reference cluster.apply().

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@DavidAdaRH DavidAdaRH self-assigned this Apr 9, 2026
@DavidAdaRH DavidAdaRH added test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks test-additional-notebooks labels Apr 9, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

@DavidAdaRH: This pull request references RHOAIENG-29722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Issue link

https://redhat.atlassian.net/browse/RHOAIENG-29722

What changes have been made

  • Notebook markdown in three demos now says cluster.apply() instead of up() (code was already apply()).

Verification steps

  • Verify those cells: text and code both reference cluster.apply().

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szaher for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DavidAdaRH
DavidAdaRH marked this pull request as ready for review April 9, 2026 15:03
@DavidAdaRH
DavidAdaRH marked this pull request as draft April 9, 2026 15:03
@DavidAdaRH
DavidAdaRH marked this pull request as ready for review April 9, 2026 15:03
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2026
@openshift-ci
openshift-ci Bot requested review from Fiona-Waters and chipspeak April 9, 2026 15:03
@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.52%. Comparing base (fc06704) to head (de1cab3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files          23       23           
  Lines        2271     2271           
=======================================
  Hits         2192     2192           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
openshift-ci Bot requested review from laurafitzgerald and szaher April 9, 2026 15:04
@laurafitzgerald

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2026
@DavidAdaRH
DavidAdaRH merged commit dfaf209 into project-codeflare:main Apr 9, 2026
19 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference lgtm Indicates that a PR is ready to be merged. test-additional-notebooks test-guided-notebooks Run PR check to verify Guided notebooks test-ui-notebooks Run PR check to verify UI notebooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants